azure-cli-extensions
azure-cli-extensions copied to clipboard
add --ampls-resource-id and --enable-high-log-scale-mode options
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
- [x] Have you run
azdev style <YOUR_EXT>locally? (pip install azdevrequired) - [x] Have you run
python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required) - [x] My extension version conforms to the Extension version schema
For new extensions:
- [x] My extension description/summary conforms to the Extension Summary Guidelines.
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.
⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message ⚠️ 1006 - ParaAdd aks addon enable cmd aks addon enableadded parameterampls_resource_id⚠️ 1006 - ParaAdd aks addon enable cmd aks addon enableadded parameterenable_high_log_scale_mode⚠️ 1006 - ParaAdd aks addon update cmd aks addon updateadded parameterampls_resource_id⚠️ 1006 - ParaAdd aks addon update cmd aks addon updateadded parameterenable_high_log_scale_mode⚠️ 1006 - ParaAdd aks create cmd aks createadded parameterampls_resource_id⚠️ 1006 - ParaAdd aks create cmd aks createadded parameterenable_high_log_scale_mode⚠️ 1006 - ParaAdd aks enable-addons cmd aks enable-addonsadded parameterampls_resource_id⚠️ 1006 - ParaAdd aks enable-addons cmd aks enable-addonsadded parameterenable_high_log_scale_mode
Thank you for your contribution! We will review the pull request and get back to you soon.
- For more info about extension versioning, please refer to Extension version schema
please fix the CI issues
Hi, @yanzhudd , @FumingZhang - CI test failures not to related to this PR and CI test failures related to this test "FAILED src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py::AzureKubernetesServiceScenarioTest::test_aks_create_with_pod_ip_allocation_mode_static_block" and I see same CI tests failures in other PRs also.
/azp run
Azure Pipelines successfully started running 2 pipeline(s).
lgtm
Queued live test to validate the change.
- test_aks_create_with_monitoring_aad_auth_with_highlogscale
- test_aks_create_with_private_cluster_with_monitoring_aad_auth_msi_with_ampls
- test_aks_create_with_private_cluster_with_monitoring_aad_auth_msi_with_ampls_with_highlogscale
failed with error
- azure.cli.testsdk.exceptions.JMESPathCheckAssertionError: Query 'properties.dataCollectionEndpointId' doesn't yield expected value '/subscriptions/79a7390d-3a85-432d-9f6f-a11a703c8b83/resourceGroups/clitestfk7a24nt2b/providers/Microsoft.Insights/dataCollectionEndpoints/MSCI-ingest-westus2-cliakstestgm5hrh', instead the actual value is '/subscriptions/79a7390d-3a85-432d-9f6f-a11a703c8b83/resourceGroups/clitestfk7a24nt2b/providers/Microsoft.Insights/dataCollectionEndpoints/MSCI-westus2-cliakstestgm5hrh'. Data: ...
- azure.cli.core.azclierror.HTTPError: Not Found({"error":{"code":"ResourceNotFound"}})
Requeued test
Requeued another live test
Queued live test
- test_aks_create_with_monitoring_aad_auth_with_highlogscale
- test_aks_create_with_private_cluster_with_monitoring_aad_auth_msi_with_ampls
- test_aks_create_with_private_cluster_with_monitoring_aad_auth_msi_with_ampls_with_highlogscale
/azp run
Azure Pipelines successfully started running 2 pipeline(s).
Live test failed
Please fix style issues. https://dev.azure.com/azclitools/public/_build/results?buildId=177380&view=logs&j=506b8f13-8269-5210-246e-a3964e53141e&t=db7247cb-300d-5b59-fd6c-6258fad20b89&l=152
ERROR: ************* Module azext_aks_preview._helpers src/aks-preview/azext_aks_preview/_helpers.py:346:11: W0718: Catching too general exception Exception (broad-exception-caught) src/aks-preview/azext_aks_preview/_helpers.py:338:19: W1508: os.getenv default type is builtins.bool. Expected str or None. (invalid-envvar-default)
Requeued live test, test passed!
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=177816&view=results