azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

add --ampls-resource-id and --enable-high-log-scale-mode options

Open ganga1980 opened this issue 1 year ago • 8 comments


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • [x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [x] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

ganga1980 avatar Jun 28 '24 05:06 ganga1980

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd aks addon enable cmd aks addon enable added parameter ampls_resource_id
⚠️ 1006 - ParaAdd aks addon enable cmd aks addon enable added parameter enable_high_log_scale_mode
⚠️ 1006 - ParaAdd aks addon update cmd aks addon update added parameter ampls_resource_id
⚠️ 1006 - ParaAdd aks addon update cmd aks addon update added parameter enable_high_log_scale_mode
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter ampls_resource_id
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter enable_high_log_scale_mode
⚠️ 1006 - ParaAdd aks enable-addons cmd aks enable-addons added parameter ampls_resource_id
⚠️ 1006 - ParaAdd aks enable-addons cmd aks enable-addons added parameter enable_high_log_scale_mode

Thank you for your contribution! We will review the pull request and get back to you soon.

yonzhan avatar Jun 28 '24 05:06 yonzhan

github-actions[bot] avatar Jun 28 '24 05:06 github-actions[bot]

please fix the CI issues

yanzhudd avatar Jul 01 '24 02:07 yanzhudd

Hi, @yanzhudd , @FumingZhang - CI test failures not to related to this PR and CI test failures related to this test "FAILED src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py::AzureKubernetesServiceScenarioTest::test_aks_create_with_pod_ip_allocation_mode_static_block" and I see same CI tests failures in other PRs also.

ganga1980 avatar Jul 01 '24 03:07 ganga1980

/azp run

FumingZhang avatar Jul 01 '24 04:07 FumingZhang

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Jul 01 '24 04:07 azure-pipelines[bot]

lgtm

Queued live test to validate the change.

  • test_aks_create_with_monitoring_aad_auth_with_highlogscale
  • test_aks_create_with_private_cluster_with_monitoring_aad_auth_msi_with_ampls
  • test_aks_create_with_private_cluster_with_monitoring_aad_auth_msi_with_ampls_with_highlogscale

failed with error

  • azure.cli.testsdk.exceptions.JMESPathCheckAssertionError: Query 'properties.dataCollectionEndpointId' doesn't yield expected value '/subscriptions/79a7390d-3a85-432d-9f6f-a11a703c8b83/resourceGroups/clitestfk7a24nt2b/providers/Microsoft.Insights/dataCollectionEndpoints/MSCI-ingest-westus2-cliakstestgm5hrh', instead the actual value is '/subscriptions/79a7390d-3a85-432d-9f6f-a11a703c8b83/resourceGroups/clitestfk7a24nt2b/providers/Microsoft.Insights/dataCollectionEndpoints/MSCI-westus2-cliakstestgm5hrh'. Data: ...
  • azure.cli.core.azclierror.HTTPError: Not Found({"error":{"code":"ResourceNotFound"}})

Requeued test

FumingZhang avatar Jul 01 '24 06:07 FumingZhang

Requeued another live test

FumingZhang avatar Jul 16 '24 02:07 FumingZhang

Queued live test

  • test_aks_create_with_monitoring_aad_auth_with_highlogscale
  • test_aks_create_with_private_cluster_with_monitoring_aad_auth_msi_with_ampls
  • test_aks_create_with_private_cluster_with_monitoring_aad_auth_msi_with_ampls_with_highlogscale

FumingZhang avatar Jul 22 '24 05:07 FumingZhang

/azp run

FumingZhang avatar Jul 29 '24 05:07 FumingZhang

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Jul 29 '24 05:07 azure-pipelines[bot]

Live test failed

FumingZhang avatar Jul 30 '24 06:07 FumingZhang

Please fix style issues. https://dev.azure.com/azclitools/public/_build/results?buildId=177380&view=logs&j=506b8f13-8269-5210-246e-a3964e53141e&t=db7247cb-300d-5b59-fd6c-6258fad20b89&l=152

ERROR: ************* Module azext_aks_preview._helpers src/aks-preview/azext_aks_preview/_helpers.py:346:11: W0718: Catching too general exception Exception (broad-exception-caught) src/aks-preview/azext_aks_preview/_helpers.py:338:19: W1508: os.getenv default type is builtins.bool. Expected str or None. (invalid-envvar-default)

Requeued live test, test passed!

FumingZhang avatar Jul 31 '24 06:07 FumingZhang

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=177816&view=results

azclibot avatar Aug 01 '24 04:08 azclibot