azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

{AKS} Set disable local accounts to true when creating an automatic cluster

Open xmzhao0822 opened this issue 9 months ago • 8 comments


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create -g xmrg -n xmmc --sku automatic

General Guidelines

  • [x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [x] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

xmzhao0822 avatar May 06 '24 23:05 xmzhao0822

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Hi @xmzhao0822, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

AKS

yonzhan avatar May 06 '24 23:05 yonzhan

For more info about extension versioning, please refer to Extension version schema

github-actions[bot] avatar May 06 '24 23:05 github-actions[bot]

The change looks good, waiting for feature owner to provide a proof of passed live test

FumingZhang avatar May 07 '24 03:05 FumingZhang

The change looks good, waiting for feature owner to provide a proof of passed live test

Do I need to push the live passed recordings change at here?

xmzhao0822 avatar May 07 '24 04:05 xmzhao0822

The change looks good, waiting for feature owner to provide a proof of passed live test

Do I need to push the live passed recordings change at here?

the recording file is not that important, it would be great if the live test pipeline could pass, I queued another one in eastus

FumingZhang avatar May 07 '24 04:05 FumingZhang

The change looks good, waiting for feature owner to provide a proof of passed live test

Do I need to push the live passed recordings change at here?

the recording file is not that important, it would be great if the live test pipeline could pass, I queued another one in eastus

The live test pipeline in the EastUS has passed :)

xmzhao0822 avatar May 07 '24 05:05 xmzhao0822

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=155564&view=results

azclibot avatar May 07 '24 06:05 azclibot