azure-cli-extensions
azure-cli-extensions copied to clipboard
[ContainerApp] Add CLI for DotNet Components
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
PR Description - This adds CLI support for to create/show/list/delete DotNet components.
General Guidelines
- [x] Have you run
azdev style <YOUR_EXT>
locally? (pip install azdev
required) - [ ] Have you run
python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required) - [ ] My extension version conforms to the Extension version schema
For new extensions:
- [ ] My extension description/summary conforms to the Extension Summary Guidelines.
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json
automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json
.
⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message ⚠️ 1011 - SubgroupAdd containerapp env dotnet-component sub group containerapp env dotnet-component
added
Hi @snehapar9, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.
Hi @snehapar9, Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.
ContainerApp
:warning: Release Suggestions
Module: containerapp
- Update
VERSION
to1.0.0b1
insrc/containerapp/setup.py
Notes
- Stable/preview tag is inherited from last release. If needed, please add
stable
/preview
label to modify it. - Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add
major
/minor
/patch
/pre
label to adjust it. - For more info about extension versioning, please refer to Extension version schema
@snehapar9 In the Integration tests failed, it is due to the vnet api-version update, you can follow some doc to pull azure-cli dev branch latest code and setup:
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_dotnet_component.py::ContainerappDotNetComponentTests::test_containerapp_dotnet_component
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_env_commands.py::ContainerappEnvScenarioTest::test_containerapp_env_infrastructure_rg
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_nfsazurefile.py::ContainerAppMountNfsAzureFileTest::test_container_app_mount_nfsazurefile_e2e
But about these two tests I have rerun them in this PR: https://github.com/Azure/azure-cli-extensions/pull/7382, which will be merged after Chinese holiday.
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_env_commands.py::ContainerappEnvScenarioTest::test_containerapp_env_infrastructure_rg
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_nfsazurefile.py::ContainerAppMountNfsAzureFileTest::test_container_app_mount_nfsazurefile_e2e
Thank you so much for your kind cooperation. I would like to inform you that I don't have experience in this regard, so I'm requesting your favor to resolve this matter if possible!
With Regards,
Moazzem Hossain
From: Moazzem Hossain @.> Sent: 07 May 2024 4:57 PM To: Azure/azure-cli-extensions @.> Cc: Subscribed @.***> Subject: Re: [Azure/azure-cli-extensions] [ContainerApp] Add CLI for DotNet Components (PR #7564)
@Moazzem-Hossain-pixel approved this pull request.
Need support
— Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-cli-extensions/pull/7564#pullrequestreview-2042844472, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BG2VRVA36JYLMFGQQ5SGBVDZBCXTLAVCNFSM6AAAAABG7E5OTCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBSHA2DINBXGI. You are receiving this because you are subscribed to this thread.Message ID: @.***>
@snehapar9 In the Integration tests failed, it is due to the vnet api-version update, you can follow some doc to pull azure-cli dev branch latest code and setup:
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_dotnet_component.py::ContainerappDotNetComponentTests::test_containerapp_dotnet_component FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_env_commands.py::ContainerappEnvScenarioTest::test_containerapp_env_infrastructure_rg FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_nfsazurefile.py::ContainerAppMountNfsAzureFileTest::test_container_app_mount_nfsazurefile_e2e
But about these two tests I have rerun them in this PR: #7382, which will be merged after Chinese holiday.
FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_env_commands.py::ContainerappEnvScenarioTest::test_containerapp_env_infrastructure_rg FAILED src/containerapp/azext_containerapp/tests/latest/test_containerapp_nfsazurefile.py::ContainerAppMountNfsAzureFileTest::test_container_app_mount_nfsazurefile_e2e
@Greedygre I pulled latest from dev branch on azure-cli and re-ran azdev setup --cli C:/Repos/azure-cli --repo . -e containerapp
I'm still seeing integration test failure ( I pushed a new recording). Can you please help take a look? I've verified that it passes locally
Please fix CI issues.