azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

Add sessionpool CRUD

Open yalixiang opened this issue 1 year ago • 6 comments


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • [x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [ ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [ ] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

yalixiang avatar Apr 29 '24 06:04 yalixiang

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd containerapp sessionpool sub group containerapp sessionpool added

Hi @yalixiang, Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Hi @yalixiang, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

Thank you for your contribution! We will review the pull request and get back to you soon.

yonzhan avatar Apr 29 '24 06:04 yonzhan

:warning: Release Suggestions

Module: containerapp

  • Update VERSION to 1.0.0b1 in src/containerapp/setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

github-actions[bot] avatar Apr 29 '24 06:04 github-actions[bot]

Please fix CI issues

yonzhan avatar Apr 29 '24 14:04 yonzhan

Thank you so much for your cooperation. I am sorry to say, I don't have experience in this regard, as because unable to give proper support. If you can help me to resolve this issue that will be highly appreciated.

Best Regards,

Moazzem Hossain

From: yalixiang @.> Sent: 07 May 2024 3:00 PM To: Azure/azure-cli-extensions @.> Cc: Moazzem Hossain @.>; Comment @.> Subject: Re: [Azure/azure-cli-extensions] Add sessionpool CRUD (PR #7559)

@yalixiang commented on this pull request.


In src/containerapp/azext_containerapp/containerapp_sessionpool_decorator.pyhttps://github.com/Azure/azure-cli-extensions/pull/7559#discussion_r1592076058:

  • def set_up_network_configuration(self):
  •    session_network_def = {}
    
  •    if self.get_argument_egress_enabled() is None:
    
  •        self.set_argument_egress_enabled(False)
    
  •    session_network_def['status'] = convert_egress_parameter(self.get_argument_egress_enabled())
    
  •    return session_network_def
    

Like discussed offline, I would like to keep it. thank you.

— Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-cli-extensions/pull/7559#discussion_r1592076058, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BG2VRVGROALQFDIFVFUYWUTZBCJ3LAVCNFSM6AAAAABG5WRI7OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBSGUZDAOBWGE. You are receiving this because you commented.

MoazzemHossain-bot avatar May 07 '24 09:05 MoazzemHossain-bot

Recommend title: [Container app] az containerapp sessionpool: Support sessionpool command.

And please update history.rst

Greedygre avatar May 14 '24 02:05 Greedygre