azure-cli-extensions
azure-cli-extensions copied to clipboard
Add Workaround to MSAL PoP tokens being cached
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az connectedk8s
General Guidelines
- [X] Have you run
azdev style <YOUR_EXT>locally? (pip install azdevrequired) - [X] Have you run
python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required) - [X] My extension version conforms to the Extension version schema
For new extensions:
- [ ] My extension description/summary conforms to the Extension Summary Guidelines.
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.
Hi @JorgeDaboub, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.
Hi @JorgeDaboub, Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.
️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes
Thank you for your contribution! We will review the pull request and get back to you soon.
This PR is needed because of a change in MSAL in which when we try to get a token to use for our PoP scenario, it is mistakenly providing cached tokens with the wrong Key ID resulting in a mismatch and failure when trying to validate the token.
I have an open PR to fix the issue, but this will mitigate the issue in the meantime.
:warning: Release Suggestions
Module: connectedk8s
- Update version to
1.7.1in setup.py
Notes
- Stable/preview tag is inherited from last release. If needed, please add
stable/previewlabel to modify it. - Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add
major/minor/patch/prelabel to adjust it. - For more info about extension versioning, please refer to Extension version schema
@JorgeDaboub Please take a look at this comment https://github.com/Azure/azure-cli-extensions/pull/7556#issuecomment-2080232048
@zhoxing-ms Updated as requested. Should be good to merge. Thanks
Hi all @zhoxing-ms @yonzhan @jsntcy @yanzhudd
Apologize for the global ping. This PR is required to fix a broken scenario, with customer impact. We would really appreciate your help in merging and releasing this as soon as possible.
Thanks!
[Release] Update index.json for extension [ connectedk8s ] : https://dev.azure.com/azclitools/release/_build/results?buildId=154883&view=results