azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

Address bastion native client Issues and add proper error messages

Open Tejaswikandula opened this issue 1 year ago • 7 comments

This PR addresses the following bastion native client Issues

  1. Add proper error message when --target-ip-address flag when IpConnect is disabled

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • [x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [ ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [ ] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Tejaswikandula avatar Apr 26 '24 19:04 Tejaswikandula

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Hi @Tejaswikandula, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

Hi @Tejaswikandula, Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Thank you for your contribution! We will review the pull request and get back to you soon.

yonzhan avatar Apr 26 '24 19:04 yonzhan

For more info about extension versioning, please refer to Extension version schema

github-actions[bot] avatar Apr 26 '24 19:04 github-actions[bot]

please record the test cases based on the latest azure-cli

necusjz avatar May 06 '24 03:05 necusjz

Please fix CI issues

yonzhan avatar May 16 '24 22:05 yonzhan

[Release] Update index.json for extension [ bastion ] : https://dev.azure.com/azclitools/release/_build/results?buildId=164689&view=results

azclibot avatar Jun 12 '24 06:06 azclibot