azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

[ContainerApp] Modofied cloud build logic to use simplified ARM calls

Open harryli0108 opened this issue 1 year ago • 9 comments


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp up az containerapp create az containerapp update

General Guidelines

  • [x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [x] My extension version conforms to the Extension version schema

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

harryli0108 avatar Apr 17 '24 21:04 harryli0108

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Hi @harryli0108, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

ContainerApp

yonzhan avatar Apr 17 '24 21:04 yonzhan

This PR is continuing the works included from #7413

harryli0108 avatar Apr 17 '24 21:04 harryli0108

:warning: Release Suggestions

Module: containerapp

  • Update VERSION to 1.0.0b1 in src/containerapp/setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

github-actions[bot] avatar Apr 17 '24 21:04 github-actions[bot]

Hi @harryli0108 I am going to upgrade the api-version to 2024-02-02-preview early this week, you can wait for this and rerun your new tests.

Greedygre avatar Apr 22 '24 02:04 Greedygre

Please fix CI issues

yonzhan avatar Apr 22 '24 07:04 yonzhan

Hi @harryli0108 I am going to upgrade the api-version to 2024-02-02-preview early this week, you can wait for this and rerun your new tests.

Hi @harryli0108 @Moazzem-Hossain-pixel After this PR merged: https://github.com/Azure/azure-cli-extensions/pull/7545 You can sync the main branch, then the CI can resolve.

And please rerun this PR changed commands related tests with --live.

Greedygre avatar Apr 25 '24 08:04 Greedygre

Hi @harryli0108 Pleas follow the review process: Code Review Process When you send a new PR toAzure-CLI repo or Azure-CLI-Extensions repo, please make sure all checks in CI passed.

If the PR is to add new feature support, please get approval from your team who could be responsible for your business logic.

Greedygre avatar May 13 '24 05:05 Greedygre