azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

[NetAppFiles] Update extension to 2023-07-01-preview models

Open audunn opened this issue 1 year ago • 6 comments


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • [x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [x] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

audunn avatar Apr 09 '24 16:04 audunn

❌Azure CLI Extensions Breaking Change Test
❌netappfiles-preview
rule cmd_name rule_message suggest_message
1007 - ParaRemove netappfiles account backup-vault backup update cmd netappfiles account backup-vault backup update removed parameter use_existing_snapshot please add back parameter use_existing_snapshot for cmd netappfiles account backup-vault backup update
1007 - ParaRemove netappfiles volume create cmd netappfiles volume create removed parameter replication_id please add back parameter replication_id for cmd netappfiles volume create
1010 - ParaPropUpdate netappfiles volume create cmd netappfiles volume create update parameter smb_continuously_available: updated property options from ['--smb-ca', '--smb-continuously-available'] to ['--smb-continuously-available', '--smb-continuously-avl'] please change property options from ['--smb-continuously-available', '--smb-continuously-avl'] to ['--smb-ca', '--smb-continuously-available'] for parameter smb_continuously_available of cmd netappfiles volume create
1007 - ParaRemove netappfiles volume update cmd netappfiles volume update removed parameter remote_volume_resource_id please add back parameter remote_volume_resource_id for cmd netappfiles volume update
1007 - ParaRemove netappfiles volume update cmd netappfiles volume update removed parameter replication_id please add back parameter replication_id for cmd netappfiles volume update
1010 - ParaPropUpdate netappfiles volume update cmd netappfiles volume update update parameter smb_continuously_available: updated property options from ['--smb-ca', '--smb-continuously-available'] to ['--smb-continuously-available', '--smb-continuously-avl'] please change property options from ['--smb-continuously-available', '--smb-continuously-avl'] to ['--smb-ca', '--smb-continuously-available'] for parameter smb_continuously_available of cmd netappfiles volume update
⚠️ 1006 - ParaAdd netappfiles volume create cmd netappfiles volume create added parameter cool_access_retrieval_policy
⚠️ 1006 - ParaAdd netappfiles volume create cmd netappfiles volume create added parameter remote_path
⚠️ 1010 - ParaPropUpdate netappfiles volume create cmd netappfiles volume create update parameter network_features: updated property choices from ['Basic', 'Standard'] to ['Basic', 'Basic_Standard', 'Standard', 'Standard_Basic']
⚠️ 1010 - ParaPropUpdate netappfiles volume create cmd netappfiles volume create update parameter rules: updated property name from rules to export_policy_rules
⚠️ 1010 - ParaPropUpdate netappfiles volume create cmd netappfiles volume create update parameter rules: updated property options from ['--rules'] to ['--export-policy-rules', '--rules']
⚠️ 1008 - ParaPropAdd netappfiles volume create cmd netappfiles volume create update parameter subnet_id: added property aaz_default=default
⚠️ 1008 - ParaPropAdd netappfiles volume create cmd netappfiles volume create update parameter subnet_id: added property default=default
⚠️ 1009 - ParaPropRemove netappfiles volume create cmd netappfiles volume create update parameter subnet_id: removed property required=True
⚠️ 1010 - ParaPropUpdate netappfiles volume latest-backup-status current show cmd netappfiles volume latest-backup-status current show update parameter volume_name: updated property options from ['--volume-name'] to ['--volume-name', '-v']
⚠️ 1011 - SubgroupAdd netappfiles volume latest-restore-status sub group netappfiles volume latest-restore-status added
⚠️ 1006 - ParaAdd netappfiles volume update cmd netappfiles volume update added parameter cool_access_retrieval_policy
⚠️ 1010 - ParaPropUpdate netappfiles volume update cmd netappfiles volume update update parameter network_features: updated property choices from ['Basic', 'Standard'] to ['Basic', 'Basic_Standard', 'Standard', 'Standard_Basic']
⚠️ 1010 - ParaPropUpdate netappfiles volume update cmd netappfiles volume update update parameter rules: updated property name from rules to export_policy_rules
⚠️ 1010 - ParaPropUpdate netappfiles volume update cmd netappfiles volume update update parameter rules: updated property options from ['--rules'] to ['--export-policy-rules', '--rules']

Hi @audunn, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

NetAppFiles

yonzhan avatar Apr 09 '24 16:04 yonzhan

:warning: Release Suggestions

Module: netappfiles-preview

  • Update version to 1.0.0b2 in setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

github-actions[bot] avatar Apr 10 '24 04:04 github-actions[bot]

@audunn please also write the description of changes which can be perceived by customers into HISTORY.rst as well.

AllyW avatar Apr 15 '24 07:04 AllyW

It seems breaking changes are included. Please confirm image

kairu-ms avatar Apr 17 '24 02:04 kairu-ms