azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

align with secret store params change

Open wchigit opened this issue 10 months ago • 4 comments


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks connection create postgres-flexible --secret name=XX secret=XX

This PR is to align with the changes made in https://github.com/Azure/azure-cli/pull/28546.

General Guidelines

  • [ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [ ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [ ] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

wchigit avatar Apr 07 '24 07:04 wchigit

❌Azure CLI Extensions Breaking Change Test
❌serviceconnector-passwordless
rule cmd_name rule_message suggest_message
1007 - ParaRemove aks connection create mysql-flexible cmd aks connection create mysql-flexible removed parameter key_vault_id please add back parameter key_vault_id for cmd aks connection create mysql-flexible
1007 - ParaRemove aks connection create postgres cmd aks connection create postgres removed parameter key_vault_id please add back parameter key_vault_id for cmd aks connection create postgres
1007 - ParaRemove aks connection create postgres-flexible cmd aks connection create postgres-flexible removed parameter key_vault_id please add back parameter key_vault_id for cmd aks connection create postgres-flexible
1007 - ParaRemove aks connection create sql cmd aks connection create sql removed parameter key_vault_id please add back parameter key_vault_id for cmd aks connection create sql

Hi @wchigit, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

Thank you for your contribution! We will review the pull request and get back to you soon.

yonzhan avatar Apr 07 '24 07:04 yonzhan

:warning: Release Suggestions

Module: serviceconnector-passwordless

  • Update version to 2.0.0 in setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

github-actions[bot] avatar Apr 08 '24 02:04 github-actions[bot]