azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

Support p2p traffic encryption.

Open LGDoor opened this issue 1 year ago • 10 comments


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp env create/update

General Guidelines

  • [ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [ ] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [ ] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

LGDoor avatar Apr 07 '24 06:04 LGDoor

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd containerapp env create cmd containerapp env create added parameter p2p_encryption_enabled
⚠️ 1006 - ParaAdd containerapp env update cmd containerapp env update added parameter p2p_encryption_enabled

Hi @LGDoor, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

Thank you for your contribution! We will review the pull request and get back to you soon.

yonzhan avatar Apr 07 '24 06:04 yonzhan

:warning: Release Suggestions

Module: containerapp

  • Update VERSION to 1.0.0b1 in src/containerapp/setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

github-actions[bot] avatar Apr 08 '24 02:04 github-actions[bot]

pending on 2024-02-02-preview

LGDoor avatar Apr 19 '24 08:04 LGDoor

@Greedygre @Juliehzl plz review

LGDoor avatar May 06 '24 06:05 LGDoor

please get approval from your team who could be responsible for your business logic.

Greedygre avatar May 06 '24 06:05 Greedygre

The CI integration Failed is due to the azure-cli has upgraded api-version to 2024-03-01, I will update the recording files soon.

Greedygre avatar May 06 '24 06:05 Greedygre

@zhenqxuMSFT plz help review

LGDoor avatar May 06 '24 07:05 LGDoor

The CI integration Failed is due to the azure-cli has upgraded api-version to 2024-03-01, I will update the recording files soon.

The PR has been merged, please rebase the main.

Greedygre avatar May 07 '24 03:05 Greedygre

Recommend title: [Container app] az containerapp env create/update: Support peer-to-peer traffic encryption with --enable-peer-to-peer-encryption

Greedygre avatar May 08 '24 05:05 Greedygre