AZ AOSM Extension Refactor

[jordlay]

trafficstars

---

• History.RST and setup.py up to date for release of 2.0.0b
• Large scale refactor of az aosm extension
• Logic reviewed by responsible team
• Good unit test coverage
• Working integration tests using ScenarioTest

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

• [x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
• [x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
• [x] My extension version conforms to the Extension version schema

For new extensions:

• [ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

[azure-client-tools-bot-prd[bot]]

❌Azure CLI Extensions Breaking Change Test

❌aosm

rule	cmd_name	rule_message	suggest_message
❌ 1007 - ParaRemove	aosm nfd build	cmd aosm nfd build removed parameter force	please add back parameter force for cmd aosm nfd build
❌ 1007 - ParaRemove	aosm nfd build	cmd aosm nfd build removed parameter interactive	please add back parameter interactive for cmd aosm nfd build
❌ 1007 - ParaRemove	aosm nfd build	cmd aosm nfd build removed parameter order_params	please add back parameter order_params for cmd aosm nfd build
❌ 1002 - CmdRemove	aosm nfd delete	cmd aosm nfd delete removed	please confirm cmd aosm nfd delete removed
❌ 1006 - ParaAdd	aosm nfd publish	cmd aosm nfd publish added parameter build_output_folder	please remove parameter build_output_folder for cmd aosm nfd publish
❌ 1007 - ParaRemove	aosm nfd publish	cmd aosm nfd publish removed parameter config_file	please add back parameter config_file for cmd aosm nfd publish
❌ 1007 - ParaRemove	aosm nfd publish	cmd aosm nfd publish removed parameter definition_file	please add back parameter definition_file for cmd aosm nfd publish
❌ 1007 - ParaRemove	aosm nfd publish	cmd aosm nfd publish removed parameter manifest_file	please add back parameter manifest_file for cmd aosm nfd publish
❌ 1007 - ParaRemove	aosm nfd publish	cmd aosm nfd publish removed parameter manifest_params_file	please add back parameter manifest_params_file for cmd aosm nfd publish
❌ 1007 - ParaRemove	aosm nfd publish	cmd aosm nfd publish removed parameter parameters_json_file	please add back parameter parameters_json_file for cmd aosm nfd publish
❌ 1007 - ParaRemove	aosm nfd publish	cmd aosm nfd publish removed parameter skip	please add back parameter skip for cmd aosm nfd publish
❌ 1007 - ParaRemove	aosm nsd build	cmd aosm nsd build removed parameter force	please add back parameter force for cmd aosm nsd build
❌ 1002 - CmdRemove	aosm nsd delete	cmd aosm nsd delete removed	please confirm cmd aosm nsd delete removed
❌ 1006 - ParaAdd	aosm nsd publish	cmd aosm nsd publish added parameter build_output_folder	please remove parameter build_output_folder for cmd aosm nsd publish
❌ 1007 - ParaRemove	aosm nsd publish	cmd aosm nsd publish removed parameter config_file	please add back parameter config_file for cmd aosm nsd publish
❌ 1007 - ParaRemove	aosm nsd publish	cmd aosm nsd publish removed parameter design_file	please add back parameter design_file for cmd aosm nsd publish
❌ 1007 - ParaRemove	aosm nsd publish	cmd aosm nsd publish removed parameter manifest_file	please add back parameter manifest_file for cmd aosm nsd publish
❌ 1007 - ParaRemove	aosm nsd publish	cmd aosm nsd publish removed parameter manifest_params_file	please add back parameter manifest_params_file for cmd aosm nsd publish
❌ 1007 - ParaRemove	aosm nsd publish	cmd aosm nsd publish removed parameter parameters_json_file	please add back parameter parameters_json_file for cmd aosm nsd publish
❌ 1007 - ParaRemove	aosm nsd publish	cmd aosm nsd publish removed parameter skip	please add back parameter skip for cmd aosm nsd publish
⚠️ 1006 - ParaAdd	aosm nfd build	cmd aosm nfd build added parameter skip
⚠️ 1010 - ParaPropUpdate	aosm nfd build	cmd aosm nfd build update parameter definition_type: updated property choices from ['cnf', 'vnf'] to ['cnf', 'vnf', 'vnf-nexus']
⚠️ 1010 - ParaPropUpdate	aosm nfd generate-config	cmd aosm nfd generate-config update parameter definition_type: updated property choices from ['cnf', 'vnf'] to ['cnf', 'vnf', 'vnf-nexus']
⚠️ 1009 - ParaPropRemove	aosm nfd generate-config	cmd aosm nfd generate-config update parameter output_file: removed property default=input.json
⚠️ 1010 - ParaPropUpdate	aosm nfd publish	cmd aosm nfd publish update parameter definition_type: updated property choices from ['cnf', 'vnf'] to ['cnf', 'vnf', 'vnf-nexus']
⚠️ 1009 - ParaPropRemove	aosm nsd generate-config	cmd aosm nsd generate-config update parameter output_file: removed property default=input.json
⚠️ 1006 - ParaAdd	aosm nsd publish	cmd aosm nsd publish added parameter no_subscription_permissions
⚠️ 1011 - SubgroupAdd	aosm publisher	sub group aosm publisher added

[azure-client-tools-bot-prd[bot]]

Hi @jordlay, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

[azure-client-tools-bot-prd[bot]]

Hi @jordlay, Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

[yonzhan]

Thank you for your contribution! We will review the pull request and get back to you soon.

[pjw711]

@jordlay ,

• See https://github.com/Azure/azure-cli/blob/release/doc/extensions/versioning_guidelines.md . According to that the version we're releasing should be 2.0.0b1. It's a new preview version with breaking changes.
• The existing published version is still marked as preview - good :)

{ "experimental": false, "installed": true, "name": "aosm", "preview": true, "summary": "Microsoft Azure Command-Line Tools Aosm Extension", "version": "1.0.0b3" },

[github-actions[bot]]

:warning: Release Suggestions

Module: aosm

• Update VERSION to 1.0.0b4 in src/aosm/setup.py

Notes

• Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
• Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
• For more info about extension versioning, please refer to Extension version schema

[Cyclam]

@kairu-ms , we've added examples as requested, could you review again, please?

[yonzhan]

Please fix CI issues

[kairu-ms]

/azp run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 2 pipeline(s).

[Cyclam]

Thanks @kairu-ms . Do we need to do anything else for this to merge, or is there another button you need to press?

[kairu-ms]

Thanks @kairu-ms . Do we need to do anything else for this to merge, or is there another button you need to press?

PR merged

[azclibot]

[Release] Update index.json for extension [ aosm ] : https://dev.azure.com/azclitools/release/_build/results?buildId=159847&view=results