azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

Add Windows platform check and refactor structure definitions in azex…

Open ereli-sevenai opened this issue 1 year ago • 8 comments

This PR introduces a crucial check to ensure the azext_ssh module runs only on Windows platforms, preventing import errors on non-Windows systems.

ereli-sevenai avatar Mar 27 '24 19:03 ereli-sevenai

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Hi @ereli-okami, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

Hi @ereli-okami, Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Thank you for your contribution ereli-okami! We will review the pull request and get back to you soon.

Thank you for your contribution! We will review the pull request and get back to you soon.

yonzhan avatar Mar 27 '24 19:03 yonzhan

@microsoft-github-policy-service agree [company="Okami AI"]

ereli-sevenai avatar Mar 27 '24 19:03 ereli-sevenai

@microsoft-github-policy-service agree company="Okami AI"

ereli-sevenai avatar Mar 27 '24 19:03 ereli-sevenai

:warning: Suggestions

Module: ssh

  • Update version to 2.0.4 in setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

github-actions[bot] avatar Apr 01 '24 03:04 github-actions[bot]