azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

[AKS] Add a new command to check outbound network from nodes `az aks check-network outbound`

Open alyssa1303 opened this issue 2 years ago • 15 comments


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks check-network outbound

General Guidelines

  • [x] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [x] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

alyssa1303 avatar Feb 09 '24 20:02 alyssa1303

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd aks check-network sub group aks check-network added

Hi @alyssa1303, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

AKS

yonzhan avatar Feb 09 '24 20:02 yonzhan

Please add some unit test cases (see examples in test_helpers.py) and at least one live test case (see examples in test_aks_commands.py) for the newly added command.

don't forget this 😄

FumingZhang avatar Feb 22 '24 02:02 FumingZhang

Please add some unit test cases (see examples in test_helpers.py) and at least one live test case (see examples in test_aks_commands.py) for the newly added command.

don't forget this 😄

Yes I'm still working on it

alyssa1303 avatar Feb 23 '24 19:02 alyssa1303

Please add some unit test cases (see examples in test_helpers.py) and at least one live test case (see examples in test_aks_commands.py) for the newly added command.

I've finished adding unit test and live test. All CI passes except for the Cred run which I believe need help from CI team

alyssa1303 avatar Feb 28 '24 20:02 alyssa1303

@yanzhudd Could you please help review this PR?

zhoxing-ms avatar Feb 29 '24 04:02 zhoxing-ms

Please also resolve the merge conflicts.

FumingZhang avatar Feb 29 '24 07:02 FumingZhang

⚠️ GitGuardian has uncovered 61 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_get_customdomainverificationid_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_get_customdomainverificationid_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_storage.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_identity_system.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_identity_system.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_mtls.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_create_with_vnet_yaml.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_create_with_vnet_yaml.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_certificate_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_update_custom_domains.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_update_custom_domains.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_custom_domains_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_custom_domains_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_custom_domains_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_usages.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_custom_domains.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_update_custom_domains.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_custom_domains.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_custom_domains.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_custom_domains.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_update_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_update_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_la_dynamic_json.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_create_with_vnet_yaml.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_azurefile_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_certificate_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_certificate_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_logs_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_logs_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_logs_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_dapr_components.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_secret_update_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_dapr_components.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_dapr_components.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_nfsazurefile_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_nfsazurefile_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_storage.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_storage.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_azurefile_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_azurefile_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_container_app_mount_nfsazurefile_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_get_customdomainverificationid_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_internal_only_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_usages.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_usages.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_identity_system.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_la_dynamic_json.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_la_dynamic_json.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_la_dynamic_json.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_la_dynamic_json.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_logs_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_mtls.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_mtls.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_internal_only_e2e.yaml View secret
- Microsoft Azure Storage Account Key 650a86953a586e9b1e5410946d16f57decfd692f src/containerapp/azext_containerapp/tests/latest/recordings/test_containerapp_env_internal_only_e2e.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

gitguardian[bot] avatar Feb 29 '24 21:02 gitguardian[bot]

⚠️ GitGuardian has uncovered 61 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request 🛠 Guidelines to remediate hardcoded secrets 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.Our GitHub checks need improvements? Share your feedbacks!

Can someone help me look into this problem? Seem like a serious one but I'm pretty sure it's not from my change but something from the main branch after I got the latest change @zhoxing-ms @yanzhudd @FumingZhang

alyssa1303 avatar Mar 01 '24 00:03 alyssa1303

/azp run

FumingZhang avatar Mar 01 '24 02:03 FumingZhang

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Mar 01 '24 02:03 azure-pipelines[bot]

/azp run

FumingZhang avatar Mar 01 '24 03:03 FumingZhang

Azure Pipelines successfully started running 2 pipeline(s).

azure-pipelines[bot] avatar Mar 01 '24 03:03 azure-pipelines[bot]

:warning: Suggestions

Module: aks-preview

  • Update version to 2.0.0b8 in setup.py
  • Set azext.isPreview to true in azext_aks-preview/azext_metadata.json if not exists

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

github-actions[bot] avatar Mar 15 '24 09:03 github-actions[bot]

Default API version has been updated to 2024-02-02-preview, the recording file of test_aks_check_network is outdated so the CI failed. Requeued live test.

FumingZhang avatar Mar 28 '24 02:03 FumingZhang

Requeued another live test including recent changes. Test passed!

FumingZhang avatar Apr 02 '24 02:04 FumingZhang