azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

{storage-blob-preview} Fix Azure/azure-cli#23536: `az storage blob upload`: Clarify permissions for adding tags

Open navba-MSFT opened this issue 2 years ago • 10 comments

This task can be performed by a Storage Blob Data Owner or a security principal that has been given permission to the Microsoft.Storage/storageAccounts/blobServices/containers/blobs/tags/write

More Info: https://docs.microsoft.com/en-us/azure/storage/blobs/storage-blob-index-how-to?tabs=azure-cli#upload-a-new-blob-with-index-tags

fixes Azure/azure-cli#23536


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • [ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [ ] Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

navba-MSFT avatar Aug 17 '22 08:08 navba-MSFT

AzureStorage

yonzhan avatar Aug 17 '22 08:08 yonzhan

Hi @navba-MSFT, thanks for contribution. Currently storage-blob-extension needs test re-record so the CI is blocked. Will merge this PR after I fix the tests.

BTW, can you make the change in Azure/azure-cli repo too?

evelyn-ys avatar Aug 25 '22 02:08 evelyn-ys

@evelyn-ys I have created a PR for Azure CLI too https://github.com/Azure/azure-cli/pull/23686

navba-MSFT avatar Aug 26 '22 09:08 navba-MSFT

Hi @navba-MSFT, thanks for contribution. Currently storage-blob-extension needs test re-record so the CI is blocked. Will merge this PR after I fix the tests.

BTW, can you make the change in Azure/azure-cli repo too?

@evelyn-ys I see the other PR (https://github.com/Azure/azure-cli/pull/23686) has been merged now. Thanks for your review.

navba-MSFT avatar Aug 29 '22 04:08 navba-MSFT

Hi @navba-MSFT, thanks for contribution. Currently storage-blob-extension needs test re-record so the CI is blocked. Will merge this PR after I fix the tests.

BTW, can you make the change in Azure/azure-cli repo too?

@evelyn-ys Any update on this PR ?

navba-MSFT avatar Sep 16 '22 05:09 navba-MSFT

@navba-MSFT Will really appreciate if you can help re-record all the failed tests

evelyn-ys avatar Sep 16 '22 08:09 evelyn-ys

@navba-MSFT Will really appreciate if you can help re-record all the failed tests

@evelyn-ys I am unable to find the reason for test failure. It just says below:

image

navba-MSFT avatar Sep 16 '22 08:09 navba-MSFT

/azp run

evelyn-ys avatar Sep 16 '22 08:09 evelyn-ys

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Sep 16 '22 08:09 azure-pipelines[bot]

@navba-MSFT Will really appreciate if you can help re-record all the failed tests

@evelyn-ys I am unable to find the reason for test failure. It just says below:

image

It's just because the build has been too long to exist

evelyn-ys avatar Sep 16 '22 08:09 evelyn-ys