azure-cli-extensions
azure-cli-extensions copied to clipboard
Remove enterprise-edge extension
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
- [ ] Have you run
azdev style <YOUR_EXT>
locally? (pip install azdev
required) - [ ] Have you run
python scripts/ci/test_index.py -q
locally?
For new extensions:
- [ ] My extension description/summary conforms to the Extension Summary Guidelines.
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json
automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json
.
@yonzhan we've already moved all of these commands to the core CLI and would like to prevent future customers from installing the enterprise-edge
extension. I'm assuming that we can do that by removing the source from this repo and removing enterprise-edge
entry from the index.json. Is that correct?
@kairu-ms @zhoxing-ms @jsntcy for awareness
@StrawnSC Yes, the source code can be removed directly.
But if the az extension add -n enterprise-edge
command is used in some users' scripts to install this extension, remove index.json may cause breaking change to them, so it is recommended to remove index.json during the breaking change window of CLI (Build Event and Ignite Event)
For more details about CLI breaking change process, please refer to this doc breaking_changes.md
@zhoxing-ms are we good to merge + release this?