azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

add support for arm64 Helm binaries.

Open dcasati opened this issue 1 year ago • 1 comments

add a condition to check what architecture we will be executing Helm (arm64 or amd64). This will ensure that we download the correct binaries for that platform. Currently, on a arm64 Mac (M1/M2 processors) we are downloading the amd64 helm binary and are using Rosetta for the translation. This breaks on any other OS (e.g.: Linux) running on aarch64.

this is a WIP as the https://k8connecthelm.azureedge.net/helm/ only contains the amd64 version of helm.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • [ ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [ ] Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

dcasati avatar Jul 29 '22 15:07 dcasati

connectedk8s adds support for arm64

yonzhan avatar Jul 29 '22 23:07 yonzhan

Any update on this? (friendly ping @yonzhan)

Note: a workaround is possible by creating a symlink to the correct HELM binaries

curl https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | bash -s -- -v v3.6.3
sudo mv ~/.azure/helm/v3.6.3/linux-amd64/helm ~/.azure/helm/v3.6.3/linux-amd64/helm-old
ln -s /usr/local/bin/helm ~/.azure/helm/v3.6.3/linux-amd64/helm

XavierGeerinck avatar Feb 27 '23 08:02 XavierGeerinck

@akashkeshari Could you please help review the connectedk8s extension related PR?

zhoxing-ms avatar Feb 27 '23 11:02 zhoxing-ms

@akashkeshari CLI will support ARM64 in 2.46.0. It would be great if this extension can also work on ARM64.

Related PR: https://github.com/Azure/azure-cli/pull/24180

bebound avatar Mar 01 '23 06:03 bebound