azure-cli-extensions
azure-cli-extensions copied to clipboard
{AKS} Added namespace changes in aks cli
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
- [ ] Have you run
azdev style <YOUR_EXT>
locally? (pip install azdev
required) - [ ] Have you run
python scripts/ci/test_index.py -q
locally?
For new extensions:
- [ ] My extension description/summary conforms to the Extension Summary Guidelines.
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json
automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json
.
aks
@FumingZhang PTAL
@FumingZhang the integration test pipelines are failing with an error, "The existing cassette cannot be overwritten". Do you know how to fix this? All the other comments have been resolved.
Well, you need rebase from main branch to resolve the conflicts first, we are using 04-02-preview api now. Then you need to re-record the cassette for your test case test_aks_get_credentials_at_namespace_scope
.
Hi KarthikK123, Do these features need to be released before Microsoft Build 2022 (2022-05-24) If not, can we move this pr to next milestone Jun 2022 (2022-07-05) ?
Hi KarthikK123KarthikK123, Do these features need to be released before Microsoft Build 2022 (2022-05-24) If not, can we move this pr to next milestone Jun 2022 (2022-07-05) ?
@wangzelin007 We are planning to go preview for this feature at the end of this month, so we need the changes to be merged by then. Preferably earlier.
Hi KarthikK123KarthikK123, Do these features need to be released before Microsoft Build 2022 (2022-05-24) If not, can we move this pr to next milestone Jun 2022 (2022-07-05) ?
@wangzelin007 We are planning to go preview for this feature at the end of this month, so we need the changes to be merged by then. Preferably earlier.
Hi KarthikK123, Since we can only use azure-core==1.21.1 now. But there are some workaround:
- Please create the function case_insensitive_dict in your aks-preview directory instead of import from azure-core.
- Please delete the relevant code If you are sure you will not use the method.
Queued a pipeline to check the newly added live test cases.
/azp run
Azure Pipelines successfully started running 1 pipeline(s).
@FumingZhang it looks like the Live testing pipeline is failing because a feature flag is not registered for the subscription being used. The subscription ID is "79a7390d-3a85-432d-9f6f-a11a703c8b83". I don't have access to the subscription, could you register the feature flag for this? The flag is Microsoft.ContainerService/EnableNamespaceResourcesPreview. Please also confirm whether Microsoft.KubernetesConfiguration/Namespaces is registered. Thanks.
@KarthikK123 Sure, I am registering the feature Microsoft.KubernetesConfiguration/Namespaces
for Azure Container Service - Test. For Microsoft.ContainerService/EnableNamespaceResourcesPreview
, it has been registered. This is the sub used to test various preview features. The pipeline I manually trigger is using this sub.
For the sub AKS CLI PR Gate used in CI, it's a bare sub without any feature registered. You may exclude your test cases from the default test matrix by adding them to file src/aks-preview/azcli_aks_live_test/configs/ext_matrix_default.json
.
After registered the features, queued another pipeline to test the newly added cases.
Hi KarthikK123, Please make sure to get this pr ready to merge before 2022/05/20. Otherwise, this PR cannot catch up with the release of this sprint. And the release time of the next sprint is 2022/07/05.
Does this sprint release schedule apply to extension releases as well? I believe extension releases can be done in between as well, whenever they are ready for release, isn't it?
Hi KarthikK123, Please make sure to get this pr ready to merge before 2022/05/20. Otherwise, this PR cannot catch up with the release of this sprint. And the release time of the next sprint is 2022/07/05.
Does this sprint release schedule apply to extension releases as well? I believe extension releases can be done in between as well, whenever they are ready for release, isn't it?
Sorry, you are right. Too busy to notice that this is an extension's pr.
@FumingZhang It looks like the pipelines are failing because some KV could not be created. In the logs I see a CLI error. I have merged the latest main branch from upstream repo. Is there anything else which needs to be done to fix these tests?
@FumingZhang If you don't have any other comments on this PR, could you please approve it? We are looking to merge and release in a couple of days.
Hey @KarthikK123, could you please clean up the unrelated changes in your branch?