azure-cli-extensions
azure-cli-extensions copied to clipboard
Azure
[Feature request] Add compatibility validation between CLI extension and CLI Core "azext.minCliCoreVersion"
Feature request
Background
For Spring-cloud extension, we released 3.1.0 including introduce new SDK for 2022-03-01-preview apiVersion. However, this sdk imports a library available in Azure CLI Core from version 2.30.0, however, the azext.minCliCoreVersion for 3.1.0 is 2.25.0. Customer who uses Azure CLI among [2.25.0, 2.30.0) will failed all commands for spring-cloud extension 3.1.0.
Related PR
- Vendor AppPlatform 2022-03-01-preview SDK
- Add support for AppMSI
- Upgrade min version requirement of azure cli for spring-cloud
- #4626
Request
In the pull request of an extension, run the CI with at least 2 Azure CLI version:
- Version specified in "azext.minCliCoreVersion" for an extension.
- latest
Known issue
In src/spring-cloud/azext_spring_cloud/tests/latest/test_asc_scenario.py::ByosTest::test_persistent_storage, there is an annotation @StorageAccountPreparer(), when running the test, with azure-cli 2.34.1, it's calling to storage account with apiVersion 2020-08-01, where older azure-cli is using 2020-06-01, which mean cannot find the request in recording file. However, it's the unit test self failure, not the extension failure.
class ByosTest(ScenarioTest):
@ResourceGroupPreparer()
@StorageAccountPreparer()
def test_persistent_storage(self, resource_group, storage_account):
template = 'storage account keys list -n {} -g {} --query "[0].value" -otsv'
accountkey = self.cmd(template.format(storage_account, resource_group)).output
Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @ShichaoQiu, @yuwzho, @yucwan.
Issue Details
Feature request
Background
For Spring-cloud extension, we released 3.1.0 including introduce new SDK for 2022-03-01-preview apiVersion. However, this sdk imports a library available in Azure CLI Core from version 2.30.0, however, the azext.minCliCoreVersion for 3.1.0 is 2.25.0. Customer who uses Azure CLI among [2.25.0, 2.30.0) will failed all commands for spring-cloud extension 3.1.0.
Related PR
- Vendor AppPlatform 2022-03-01-preview SDK
- Add support for AppMSI
- Upgrade min version requirement of azure cli for spring-cloud
- #4626
Request
In the pull request of an extension, run the CI with at least 2 Azure CLI version:
- Version specified in "azext.minCliCoreVersion" for an extension.
- latest
Known issue
In src/spring-cloud/azext_spring_cloud/tests/latest/test_asc_scenario.py::ByosTest::test_persistent_storage, there is an annotation @StorageAccountPreparer(), when running the test, with azure-cli 2.34.1, it's calling to storage account with apiVersion 2020-08-01, where older azure-cli is using 2020-06-01, which mean cannot find the request in recording file. However, it's the unit test self failure, not the extension failure.
class ByosTest(ScenarioTest):
@ResourceGroupPreparer()
@StorageAccountPreparer()
def test_persistent_storage(self, resource_group, storage_account):
template = 'storage account keys list -n {} -g {} --query "[0].value" -otsv'
accountkey = self.cmd(template.format(storage_account, resource_group)).output
| Author: | jiec-msft |
|---|---|
| Assignees: | - |
| Labels: |
|
| Milestone: | Backlog |
Looks like the route by this bot is not correct, please ignore this @ShichaoQiu @yuwzho
@jsntcy With the CLI PR: https://github.com/Azure/azure-cli/pull/22676 Our extension spring 1.1.6 met the same issue again and fixed in PR: https://github.com/Azure/azure-cli-extensions/pull/5361
With the growing possibility, would you consider priority increase of this feature request?
It's in our Zn planning, and we'll discuss inside our team and prioritize accordingly.
