azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

Private Link Changes in connectedk8s CLI

Open akashkeshari opened this issue 3 years ago • 13 comments

This PR consists for changes required in connectedk8s CLI for supporting private link.

Link to doc: https://microsoft-my.sharepoint.com/:w:/p/akkeshar/EV3h-BzQhYtKujEXwB4TQHMBYDAQSON5jWc5mEKXiv9AvQ?e=cBOeeZ

This PR also has the fix for waiting for LRO operations before installing/updating arc-agents

IMP!!!! Please do not merge the PR yet. We plan to release these changes next week(5/2 - 7/2)

akashkeshari avatar Jun 15 '21 07:06 akashkeshari

Private Link

yonzhan avatar Jun 15 '21 10:06 yonzhan

/azp run

jsntcy avatar Jul 13 '21 09:07 jsntcy

Pull request contains merge conflicts.

azure-pipelines[bot] avatar Jul 13 '21 09:07 azure-pipelines[bot]

@akashkeshari, what's the status of this PR?

jsntcy avatar Jul 21 '21 10:07 jsntcy

connectedk8s

yonzhan avatar Jan 18 '22 12:01 yonzhan

connectedk8s

yonzhan avatar Apr 18 '22 11:04 yonzhan

IMP!!!! Please do not merge the PR yet. We plan to release these changes next week(5/2 - 7/2)

akashkeshari avatar Apr 28 '22 07:04 akashkeshari

@akashkeshari, since there are a lot of changes within _params.py, custom.py..., it's better to update the tests and re-record.

necusjz avatar Apr 28 '22 08:04 necusjz

@akashkeshari, since there are a lot of changes within _params.py, custom.py..., it's better to update the tests and re-record.

I have re-recorded and added new tests

akashkeshari avatar May 05 '22 15:05 akashkeshari

/azp run

zhoxing-ms avatar Jun 08 '22 07:06 zhoxing-ms

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Jun 08 '22 07:06 azure-pipelines[bot]

IMP! Please do not merge the PR yet. We plan to merge and release these changes on 6/13

akashkeshari avatar Jun 08 '22 07:06 akashkeshari

@zhoxing-ms for awareness

yonzhan avatar Jun 08 '22 07:06 yonzhan

PR is ready for merging now

akashkeshari avatar Aug 22 '22 08:08 akashkeshari

[Release] Update index.json for extension [ connectedk8s ] : https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1797331&view=results

azclibot avatar Aug 22 '22 08:08 azclibot