azure-cli-extensions icon indicating copy to clipboard operation
azure-cli-extensions copied to clipboard

[Attestation] remove hardcode endpoint in extension cloud

Open yungezz opened this issue 3 years ago • 2 comments

  • If the issue is to do with Azure CLI 2.0 in-particular, create an issue here at Azure/azure-cli

Extension name (the extension in question)

Today there's hardcode endpoint https://attest.azure.net in extension code, pls remove it from extension, but add it in cli core repo _cloud.py. Then extension read endpoint from context.

Description of issue (in as much detail as possible)


yungezz avatar Aug 19 '20 07:08 yungezz

cc @fengzhou-msft for awareness

yungezz avatar Aug 19 '20 07:08 yungezz

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @anilba06.

Issue Details
  • If the issue is to do with Azure CLI 2.0 in-particular, create an issue here at Azure/azure-cli

Extension name (the extension in question)

Today there's hardcode endpoint https://attest.azure.net in extension code, pls remove it from extension, but add it in cli core repo _cloud.py. Then extension read endpoint from context.

Description of issue (in as much detail as possible)


Author: yungezz
Assignees: houk-ms
Labels:

Service Attention, Attestation

Milestone: Backlog

ghost avatar Apr 08 '22 23:04 ghost

Hi yungezz, I checked here,https://attest.azure.net is in the /manual/_client_factory.py file, not in the /generated/_client_factory.py file. (The link in your issue is /generated/_client_factory.py) May I ask if the current situation needs to be changed?

ZengTaoxu avatar Nov 09 '23 08:11 ZengTaoxu