avdaccelerator
avdaccelerator copied to clipboard
Fix TF Module References
Overview/Summary
PS C:\Users\mbratschun\repos\avdaccelerator\workload\terraform\greenfield\AADscenario> terraform init
Initializing the backend...
Initializing modules...
- personal in ..\..\modules\avd\personal
╷
│ Error: Module is incompatible with count, for_each, and depends_on
│
│ on main.tf line 68, in module "personal":
│ 68: depends_on = [module.avdi.avdLocation]
│
│ The module at module.personal is a legacy module which contains its own local provider configurations, and so calls to it may not use the count, for_each, or depends_on arguments.
│
│ If you also control the module "../../modules/avd/personal", consider updating this module to instead expect provider configurations to be passed by its caller.
╵
This PR fixes/adds/changes/removes
- Updated commented module references to include /avd in paths
- Remove the empty local provider configuration in the personal module
Breaking Changes
- Replace me
- Replace me
Testing Evidence
As part of this Pull Request I have
- [x] Read the Contribution Guide and ensured this PR is compliant with the guide
- [x] Ensured the resource API versions in
.bicep
file/s I am adding/editing are using the latest API version possible - [x] Checked for duplicate Pull Requests
- [x] Associated it with relevant GitHub Issues
- [x] (AVD LZA Team Only) Associated it with relevant ADO Items
- [x] Ensured my code/branch is up-to-date with the latest changes in the
main
branch - [x] Performed testing and provided evidence.
- [x] Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)
hold merge
@jensheerin please help us checking this one.
@danycontre this will not be merged. The AVM module was used instead. Please close.