avdaccelerator icon indicating copy to clipboard operation
avdaccelerator copied to clipboard

Published 20 hours ago • verified publisher icon Azure

WAF compliancy patch for adding DDoS protection plan

Open yahanda opened this issue 10 months ago • 1 comments

Overview/Summary

Adding DDoS network protection option to be completely WAF compliant as per ADO Items below: https://dev.azure.com/CSUSolEng/Accelerator%20-%20AVD/_workitems/edit/34480/ https://dev.azure.com/CSUSolEng/Accelerator%20-%20AVD/_workitems/edit/34047/

This PR fixes/adds/changes/removes

  1. The DDoS network protection is not enabled by default. We can include in the accelerator the option to enable DDoS protection on the Vnet.

Breaking Changes

  1. Replace me
  2. Replace me

Testing Evidence

Tested from the link below https://portal.azure.com/#blade/Microsoft_Azure_CreateUIDef/CustomDeploymentBlade/uri/https%3A%2F%2Fraw.githubusercontent.com%2Fyahanda%2Favdaccelerator-bicep-edits%2Fwaf-compliancy-patch-3%2Fworkload%2Farm%2Fdeploy-baseline.json/uiFormDefinitionUri/https%3A%2F%2Fraw.githubusercontent.com%2Fyahanda%2Favdaccelerator-bicep-edits%2Fwaf-compliancy-patch-3%2Fworkload%2Fportal-ui%2Fportal-ui-baseline.json

Added checkbox for DDoS network protection image

Deployed successfully image

Successfully added DDoS protection plan on vnet image

As part of this Pull Request I have

  • [x] Read the Contribution Guide and ensured this PR is compliant with the guide
  • [x] Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
  • [x] Checked for duplicate Pull Requests
  • [x] Associated it with relevant GitHub Issues
  • [x] (AVD LZA Team Only) Associated it with relevant ADO Items
  • [x] Ensured my code/branch is up-to-date with the latest changes in the main branch
  • [x] Performed testing and provided evidence.
  • [x] Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Docs etc.)

yahanda avatar Apr 11 '24 08:04 yahanda

@yahanda thanks for your contribution, please sync changes from Azure/main to your fork/branch and let us now once updated so we can continue the review process.

@swathibhat1 @moisesjgomez

danycontre avatar Jul 09 '24 18:07 danycontre

Hi @danycontre, I have merged the latest main repo into my branch. Please review it.

yahanda avatar Jul 10 '24 17:07 yahanda

@yahanda thanks for you contribution

danycontre avatar Jul 19 '24 19:07 danycontre