apiops icon indicating copy to clipboard operation
apiops copied to clipboard

feat: uncommenting item that reflects on the document links problem

Open felipementel opened this issue 1 year ago • 4 comments

I believe the issue in item #607 will be resolved with this commit.

felipementel avatar Sep 12 '24 16:09 felipementel

Hi @waelkdouh, how are you?

Just like in my first comment on this pull request, I believe I have found the problem that is breaking the documentation links, and for that I originally created this pull request.

Today I updated the packages that need updating, and I have combined them in this same pull request.

If I think this could negatively affect the repository, I can cancel this request and create two separate ones.

I await your contact, thank you

felipementel avatar Sep 18 '24 10:09 felipementel

Hi @felipementel could you elaborate a bit more on what you mean by it could pretend it could negatively affect this repository? I'm just trying to understand why you are suggesting creating two separate requests.

waelkdouh avatar Sep 18 '24 11:09 waelkdouh

@waelkdouh The reason would be the scope of the update.

There is a request for a documentation update, which refers to the problem and another scope, which is the update of the nuget packages.

unfortunately, due to a "mistake" of mine, I combined everything in the same PR

felipementel avatar Sep 18 '24 12:09 felipementel

Gotcha. No worries I will review and report back here accordingly. Thanks again for your contributions.

waelkdouh avatar Sep 18 '24 13:09 waelkdouh

hello @waelkdouh Do you have any expectations of when or if my pull request will be approved?

felipementel avatar Dec 16 '24 11:12 felipementel

hello @waelkdouh Do you have any expectations of when or if my pull request will be approved?

Hi @felipementel apologies for the delay. I went ahead and merged the PR. Thank you for your contributions!

waelkdouh avatar Dec 16 '24 13:12 waelkdouh

@waelkdouh

I tested and all links are ok now

image

thanks

felipementel avatar Dec 19 '24 16:12 felipementel