apiops icon indicating copy to clipboard operation
apiops copied to clipboard

Use latest version AzDo replacetokens task

Open jeroenmaes opened this issue 1 year ago • 7 comments

Update to version 6 of the AzDo replace tokens task. Version 3 is marked as deprecated.

jeroenmaes avatar Apr 17 '24 15:04 jeroenmaes

Hi,

I think you also need to update some of the input parameter that were renamed in v6 of the tasks. There is all the breaking changes on the marketplace page: https://marketplace.visualstudio.com/items?itemName=qetza.replacetokens

From a quick review, I can see the following changes that will impact the current pipeline:

  • renamed input targetFiles to sources
  • renamed input writeBOM to addBOM
  • renamed input verbosity to logLevel
    • removed verbosity value off (see new supported values for replacement)
  • renamed input actionOnMissing to missingVarLog
  • replaced keepToken with missingVarAction with value keep

vandriot avatar Apr 19 '24 12:04 vandriot

@jeroenmaes can you please refer to the changes that @vandriot is suggesting. Also any chance you can take a look at the GitHub actions implementation to see if there are similar required changes there as well?

waelkdouh avatar Apr 19 '24 12:04 waelkdouh

@jeroenmaes can you please refer to the changes that @vandriot is suggesting. Also any chance you can take a look at the GitHub actions implementation to see if there are similar required changes there as well?

Will do

jeroenmaes avatar Jun 04 '24 07:06 jeroenmaes

Hi we just released v6 release candidate. Can you please try to apply your PR on the new code base?

waelkdouh avatar Jul 03 '24 20:07 waelkdouh

@jeroenmaes and @waelkdouh

There are many break changes from any version to v6

https://marketplace.visualstudio.com/items?itemName=qetza.replacetokens

https://github.com/qetza/replacetokens-task/discussions/34

felipementel avatar Sep 02 '24 19:09 felipementel

@felipementel what are you suggesting we do?

waelkdouh avatar Sep 03 '24 03:09 waelkdouh

@felipementel what are you suggesting we do?

There are two PR with the same subject #622 and #533

felipementel avatar Sep 04 '24 21:09 felipementel

@felipementel what are you suggesting we do?

There are two PR with the same subject #622 and #533

Hi Felipe. Did you have the chance to test the changes in both PRs? I will wait on your signal before I approve.

waelkdouh avatar Dec 16 '24 14:12 waelkdouh

My change is already implemented in #676

jeroenmaes avatar Dec 17 '24 15:12 jeroenmaes