apiops icon indicating copy to clipboard operation
apiops copied to clipboard

[BUG] Configuration changes not deploying when publishing commit

Open steebwba opened this issue 2 years ago • 2 comments

Release version

v4.6.0

Describe the bug

I have a commit which updates an API policy and also updated a named value in each environment configuration yaml file. When running the publisher with the commit ID, the policy is published but the named values have not been updated. I can see changes were made in 2022 for this: #77, but the publisher class has changed substantially since then so not sure if a regression?

Expected behavior

All changes for a given commit should be published, including environment config

Actual behavior

Only artefacts are published, ignoring configuration files

Reproduction Steps

Using publisher version 4.6.0, create a commit that changes an artefact which isn't related to the configuration being modified, and also update the environment configuration file. In my case it was a policy.xml and configuration for all environments for a named value which was already referenced by the modified policy.

steebwba avatar Nov 13 '23 10:11 steebwba

  Thank you for opening this issue! Please be patient while we will look into it and get back to you as this is an open source project. In the meantime make sure you take a look at the [closed issues](https://github.com/Azure/apiops/issues?q=is%3Aissue+is%3Aclosed) in case your question has already been answered. Don't forget to provide any additional information if needed (e.g. scrubbed logs, detailed feature requests,etc.).
  Whenever it's feasible, please don't hesitate to send a Pull Request (PR) our way. We'd greatly appreciate it, and we'll gladly assess and incorporate your changes.

github-actions[bot] avatar Nov 13 '23 10:11 github-actions[bot]

@guythetechie thoughts on this one?

waelkdouh avatar Nov 13 '23 11:11 waelkdouh

please try v6 and let us know if its resolves your issue.

waelkdouh avatar Jul 05 '24 15:07 waelkdouh