aks-engine icon indicating copy to clipboard operation
aks-engine copied to clipboard

delete minor unreachable code caused by log.Fatal

Open Abirdcfly opened this issue 1 year ago • 4 comments

Signed-off-by: Abirdcfly [email protected]

Reason for Change:

Issue Fixed:

Credit Where Due:

Does this change contain code from or inspired by another project?

  • [x] No
  • [ ] Yes

If "Yes," did you notify that project's maintainers and provide attribution?

  • [ ] No
  • [ ] Yes

Requirements:

Notes:

Abirdcfly avatar Aug 09 '22 13:08 Abirdcfly

💖 Thanks for opening your first pull request! 💖 We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should make sure your first commit and PR title start with a semantic prefix. Examples of commit messages with semantic prefixes: - fix: change azure disk cachingMode to ReadOnly - feat: make maximumLoadBalancerRuleCount configurable - docs: add note on AKS Engine and AKS relationship Make sure to check out the developer guide for guidance on testing your change.

welcome[bot] avatar Aug 09 '22 13:08 welcome[bot]

/azp run pr-e2e

jackfrancis avatar Aug 12 '22 11:08 jackfrancis

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 12 '22 11:08 azure-pipelines[bot]

@Abirdcfly, thanks for this! Unfortunately we'll have to rebase this on top of current master branch before we can merge.

jackfrancis avatar Aug 12 '22 11:08 jackfrancis

@Abirdcfly, thanks for this! Unfortunately we'll have to rebase this on top of current master branch before we can merge.

Done.

Abirdcfly avatar Aug 14 '22 12:08 Abirdcfly

/azp run pr-e2e

jackfrancis avatar Aug 17 '22 23:08 jackfrancis

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Aug 17 '22 23:08 azure-pipelines[bot]

Congrats on merging your first pull request! 🎉🎉🎉

welcome[bot] avatar Aug 18 '22 21:08 welcome[bot]