aks-app-routing-operator icon indicating copy to clipboard operation
aks-app-routing-operator copied to clipboard

add configmaps to watched nic resources

Open OliverMKing opened this issue 1 year ago • 11 comments

Description

Triggers a reconcile on nic resources when a managed configmap is updated.

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

How Has This Been Tested?

E2e and unit tested. This is a core feature of how controller runtime works. It doesn't make sense to try to write a unit test for something already tested in the controller runtime package.

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation
  • [x] My changes generate no new warnings
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] New and existing unit tests pass locally with my changes
  • [x] Any dependent changes have been merged and published in downstream modules

OliverMKing avatar Nov 21 '23 21:11 OliverMKing