Azure
ACR Custom domain readme in incomplete.
What is the problem you're trying to solve ACR custom domain readme steps are partial. acr/docs/custom-domain/
Describe the solution you'd like Provide the complete steps to configure the ACR custom domain names.
Additional context Add any other context or screenshots about the feature request here.
Hi @parthasdxc,
I appreciate you bringing this to our attention. I will work with our product group team on next steps. Once I have an update, I will post it here. Thanks!
Aby update on this issue?
The current latest version of the read me is two years old and it says a custom domain is private preview feature not accepting customers. Is that still the case?
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.
Hi @mloskot @TiloGit @parthasdxc, thanks for reaching out regarding the custom domain readme. I am currently reviewing the doc to identify gaps and will update accordingly. Meanwhile, may I ask if you are still interested in previewing this feature? What gaps have you identified in your experience so far that you would like us to improve/add. Thanks!
@getk12 Thanks for picking this up, as per my https://github.com/Azure/acr/issues/674#issuecomment-1552210218 explaining availability of the feature would be a good start, I think.
@mloskot, please review the updated readme which now includes the steps for onboarding to custom domain private preview.
@getk12 Generally, this looks very good (I have not tried to try it in action though, not ready for that yet). A few nitpicks:
- https://github.com/Azure/acr/blob/2249057a28e0553c8ac21e932d88cda33460d24b/docs/custom-domain/README.md?plain=1#L70 where
we willwording confused me as may suggest to the reader those steps will be performed by Azure support team. I had to continue reading to get this clarified. - https://github.com/Azure/acr/blob/2249057a28e0553c8ac21e932d88cda33460d24b/docs/custom-domain/README.md?plain=1#L75 where
the burdenwording could be more specific. One may understand those MI-s grant access to the container registry, but that is not the case, AFAIU. The MI-s are not of clients of ACR but represent ACR itself. IOW, those MI-s are not about authenticatingdocker pullaction.
Thanks for the feedback, @mloskot. I will review and update as needed. Other than the comments, do you have any other suggestions, or may I close out this item for now? Regarding roadmap, we have ongoing discussions and will be updated in the near term.
@getk12 Although I'm not the reporter of this issue, I don't have any other suggestions, neither I see any reasons to keep it open. Thanks for the updates.