Setting `ip-address` to `Private` causes an error

[cilerler]

Setting below

    - name: 'Deploy'
      uses: azure/aci-deploy@v1
      with:
        resource-group: ${{ secrets.AZURE_RESOURCE_GROUP }}
        registry-login-server: ${{ secrets.AZURE_REGISTRY_LOGIN_SERVER }}
        registry-username: ${{ secrets.AZURE_REGISTRY_USERNAME }}
        registry-password: ${{ secrets.AZURE_REGISTRY_PASSWORD }}
        name: $DEPLOYMENT_NAME
        image: $IMAGE:$GITHUB_SHA
        location: 'south central us'
        os-type: Windows
        cpu: 4
        memory: 16
        environment-variables: DOTNET_ENVIRONMENT=Production
        restart-policy: OnFailure
        dns-name-label: $DEPLOYMENT_NAME
        ip-address: Private

throws the error below

Error: DNS name label for container group is only supported when IP Address type is public.

and removing dns-name-label throws the error below

Error: Input required and not supplied: dns-name-label

[kanika1894]

Hey @cilerler, Thanks for pointing this out. As of now, this action only supports Public IP scenario. Updated : https://github.com/Azure/aci-deploy/blob/master/action.yml#L69 Supporting Private IP will be taken up as an enhancement.

[cilerler]

Are you sure that you don't want to mark it as "Bug" since it allows you to set a value, but then it throws an error? I mean, it literally throws an error if you set Private; to me, it means a bug and not an enhancement.

[kanika1894]

Since we are calling out explicitly in the action ReadMe as well as action.yml that Private IP scenario is not supported, we'll be taking this as an enhancement.

[github-actions[bot]]

This issue is idle because it has been open for 14 days with no activity.

[zmckinnon]

I am also having this issue. Is there some reason why Private IP addresses is not supported? Any idea on the timeline on this? Are y'all accepting PRs?

[github-actions[bot]]

This issue is idle because it has been open for 14 days with no activity.

[BALAGA-GAYATRI]

@zmckinnon We are accepting PRs. We will be glad to accept contributions.

[github-actions[bot]]

This issue is idle because it has been open for 14 days with no activity.

[davemaul]

Is there a reason for this restriction? In Azure Portal it's absolutely possible to create a container instance without a dns label name and a private IP address. I'm curious. :)

[davemaul]

Tested it. There's no reason. Sent a PR. :)

[github-actions[bot]]

This issue is idle because it has been open for 14 days with no activity.

[XeniyaFesenko]

any updates on this issue?