ResourceModules icon indicating copy to clipboard operation
ResourceModules copied to clipboard

Clean up prerelease when PR is completed

Open MariusStorhaug opened this issue 3 years ago • 4 comments

Description

Should prereleases be garbage collected when the module is published in full version?

MariusStorhaug avatar Feb 10 '22 13:02 MariusStorhaug

this can be updated here https://github.com/Azure/ResourceModules/blob/main/.github/actions/templates/publishModule/action.yml

and here https://github.com/Azure/ResourceModules/blob/main/.azuredevops/pipelineTemplates/jobs.publishModule.yml

jontreynes avatar Apr 14 '22 13:04 jontreynes

As per the description - this issue is about clarifying whether to do it or not - not to implemented right way. Moving back to 'needs triage'

AlexanderSehr avatar Jul 21 '22 20:07 AlexanderSehr

Should be added as additional feature in the publish pipeline. It should also have a flag to turn the feature off.

rahalan avatar Sep 06 '22 16:09 rahalan

I'm a bit unsure about 'how' this should be implemented. Let's we introduce a flag in the settings - what should it effectively do? Upon running the publish, should it removal all versions with a '-prerelease' suffix? If so, what if there are different ones by different people? Maybe they still use the prerelease version. Etc.

AlexanderSehr avatar Jan 20 '23 11:01 AlexanderSehr