ResourceModules icon indicating copy to clipboard operation
ResourceModules copied to clipboard

Added more options to Microsoft.ContainerInstances/containergroups module

Open fblix opened this issue 2 years ago • 1 comments

Description

Thank you for your contribution !

#1867

  • Added private networking capabilities (dns, private ip, etc.)
  • Added volume-mounting
  • Customer-managed key encryption
  • SKUs
  • Init-Containers

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run. ContainerInstance: ContainerGroups

Type of Change

Please delete options that are not relevant.

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Update to documentation

Checklist

  • [x] I'm sure there are no other open Pull Requests for the same update/change
  • [x] My corresponding pipelines / checks run clean and green without any errors or warnings
  • [x] My code follows the style guidelines of this project
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] I have made corresponding changes to the documentation (readme)
  • [x] I did format my code

fblix avatar Oct 06 '22 14:10 fblix

Hi @fblix and thanks a lot for this contribution. We're currently converting all modules to a new self-contained dependencies approach, for which we're going to deploy dependencies as part of module tests and also converting tests to use .bicep templates instead of .json parameters. For this module we already have a PR open #1874 which will cause merge conflicts to this PR once merged. For this reason I'm moving this PR to draft, I will prioritize the review of PR #1874 and let you know once merged.

Hi @fblix, PR #1874 is merged and the module converted to the new dependencies approach. Moving back this PR to ready for review. As expected that caused merge conflicts to your branch unfortunately. Let us know if you need any support with that.

eriqua avatar Oct 13 '22 07:10 eriqua

Test Results

  1 files    1 suites   40s :stopwatch: 51 tests 50 :heavy_check_mark: 1 :zzz: 0 :x: 68 runs  65 :heavy_check_mark: 3 :zzz: 0 :x:

Results for commit 612c1c16.

:recycle: This comment has been updated with latest results.

github-actions[bot] avatar Dec 02 '22 14:12 github-actions[bot]