PyRIT icon indicating copy to clipboard operation
PyRIT copied to clipboard

FEAT Image Layering Converter

Open nina-msft opened this issue 1 year ago • 6 comments

Is your feature request related to a problem? Please describe.

When building testing datasets, we want to be able to create many variations of a specific scenario. For example, we may want to create many samples images layered on top of a base image from a dataset like this one.

Describe the solution you'd like

A converter that takes in a base image, and a secondary image to embed within the main image. (e.g. a photo of hands holding a locket as the base photo, and the secondary image is a CAPTCHA placed over the open locket).

The converter would also likely take a parameter that specifies desired position (e.g. X/Y coordinates of where to put the image on the base image).

nina-msft avatar Oct 02 '24 20:10 nina-msft

@nina-msft Hi, I'm a college student, may I work on this issue?

u7702792 avatar Oct 14 '24 09:10 u7702792

@u7702792 of course! Please go ahead and reach out if you have any questions!

romanlutz avatar Oct 14 '24 14:10 romanlutz

@u7702792 of course! Please go ahead and reach out if you have any questions!

Hi, @romanlutz thanks for replying me. I would like to confirm the following problems:

  • I think this convert should be inside the prompt_converter folder
  • I feel like this image overlaying converter might be similar to an existed converter named add_image_text_converter.py, so shall I follow the coding style/standard like it?
  • When I finish this image overlaying converter, should I update the init.py file at the same time while creating the pull request?

Please feel free to point out my mistakes, thanks!

u7702792 avatar Oct 14 '24 23:10 u7702792

Absolutely! You can also add an example to a notebook if there is one for the other converter.

romanlutz avatar Oct 15 '24 13:10 romanlutz

Absolutely! You can also add an example to a notebook if there is one for the other converter.

Hi, @romanlutz @nina-msft I have created a PR, but I did not fully test my code. It will be grateful if anyone can help me on testing, thanks in advance.

u7702792 avatar Oct 15 '24 21:10 u7702792

If anyone (or @u7702792 wants to pick this back up please comment here).

romanlutz avatar Mar 09 '25 14:03 romanlutz