PyRIT icon indicating copy to clipboard operation
PyRIT copied to clipboard

FEAT: Add deterministic flag and custom substitutions to LeetspeakConverter

Open KutalVolkan opened this issue 1 year ago • 1 comments

Description:

This PR introduces two new features to the LeetspeakConverter class in leetspeak_converter.py:

Deterministic Flag:

  • Adds an optional deterministic flag to the LeetspeakConverter.
  • When enabled, this flag ensures that the conversion from regular text to leetspeak is consistent across multiple runs.
  • This is particularly useful in scenarios where reproducibility of the leetspeak output is required.

Custom Substitutions:

  • Introduces support for custom leetspeak substitutions, allowing users to specify their own mappings for the conversion process.
  • This provides greater flexibility in tailoring the leetspeak output to specific needs or preferences.

Tests:

  • Some unit tests are currently failing. These will be addressed by the middle of next week.

Related Issues:

  • Issue #242

KutalVolkan avatar Aug 15 '24 08:08 KutalVolkan

Amazing! We probably want to have one test case. Can you add one?

Hello Roman,

Sure! I’ve added the test cases. Please verify them, and all feedback is welcome. I will make any necessary adjustments if needed :)

KutalVolkan avatar Aug 17 '24 08:08 KutalVolkan

Great work, @KutalVolkan!

rdheekonda avatar Aug 19 '24 23:08 rdheekonda

Great work, @KutalVolkan!

Thank you, @rdheekonda and @romanlutz, for your great support and feedback.

KutalVolkan avatar Aug 20 '24 05:08 KutalVolkan