BUG Console printer only prints objective scores if include_auxiliary_scores is set to True
Describe the bug
The title has all the information. I ran into this because the default is False and my objective score wasn't getting printed.
Expected Results
objective score gets printed even if include_auxiliary_scores is False.
Actual Results
objective score is not printed unless include_auxiliary_scores is True
Versions
This is with latest main.
Given the difficulty with determining which one the objective score actually is, I am leaning towards just displaying all scores and getting rid of the flag as it's not actually working. @raghavendarakai would you like to make that change?
So, digging into what's expected, because it's currently behaving as I would expect for the most part.
print_result_async I think behaves exactly like how you describe, because the objective score is included in the summary
print_summary_async never includes auxiliary scores
print_conversation_async includes all scores (or not).
So is the fix to change the naming? Potentially change "include_auxiliary_scores" parameter in print_conversation_async toinclude_scores?
Currently, I would expect the difference between include_auxiliary_scores being True and False to be
- True: all scores are printed
- False: only the objective scores are printed
That's not what's happening. Renaming to include_scores is fine. Or just remove the arg and always print scores? Don't see why one wouldn't want to see them...