PSRule.Rules.Azure icon indicating copy to clipboard operation
PSRule.Rules.Azure copied to clipboard

feat(new): Added Azure.APIM.AvailabilityZone.Units

Open BenjaminEngeset opened this issue 1 year ago • 3 comments

PR Summary

Fixes #2788

Added Azure.APIM.AvailabilityZone.Units.

PR Checklist

  • [x] PR has a meaningful title
  • [x] Summarized changes
  • [x] Change is not breaking
  • [x] This PR is ready to merge and is not Work in Progress
  • Rule changes
    • [x] Unit tests created/ updated
    • [x] Rule documentation created/ updated
    • [x] Link to a filed issue
    • [x] Change log has been updated with change under unreleased section
  • Other code changes
    • [ ] Unit tests created/ updated
    • [ ] Link to a filed issue
    • [ ] Change log has been updated with change under unreleased section

BenjaminEngeset avatar May 14 '24 15:05 BenjaminEngeset

Hi @BernieWhite. Let me know your thoughts on this one.

BenjaminEngeset avatar May 14 '24 15:05 BenjaminEngeset

@BernieWhite I'd also like to know what to do with the tests. With the scenarios I have added I'm causing a lot of change for the other tests already created and implemented. I can update them, but want to know before doing so, as it is some effort.

BenjaminEngeset avatar May 15 '24 13:05 BenjaminEngeset

@BenjaminEngeset Thanks for your efforts so far. I think there is duplication with Azure.APIM.AvailabilityZone. Let's park this until we confirm with Jack if there is any changes required to the existing rule.

BernieWhite avatar May 16 '24 01:05 BernieWhite

As discussed in #2788, let's close this PR and I will instead a create a new one with what we have aligned on.

BenjaminEngeset avatar May 19 '24 17:05 BenjaminEngeset