MS-AMP icon indicating copy to clipboard operation
MS-AMP copied to clipboard

DeepSpeed integration breaks existing DeepSpeed logic

Open muellerzr opened this issue 6 months ago • 2 comments

What's the issue, what's expected?:

There are attributes inside of regular deepspeed.runtime that are missing in this repo, and the monkey-patch doesn't cover, such as:

from deepspeed.runtime.lr_schedules import VALID_LR_SCHEDULES

How to reproduce it?:

from msamp import deepspeed
deepspeed.runtime.lr_schedules.VALID_LR_SCHEDULES

Log message or shapshot?:

Additional information:

Still trying to figure out a good solution here to make sure old namespaces can remain intact (as calling normal deepspeed later has consequences during training)

muellerzr avatar Aug 16 '24 18:08 muellerzr