LogicAppsUX icon indicating copy to clipboard operation
LogicAppsUX copied to clipboard

fix(vscode): Prompt for azure connector details and start design-time host on new projects

Open andrew-eldridge opened this issue 1 month ago • 2 comments

Fixes #6824

Commit Type

  • [ ] feature - New functionality
  • [x] fix - Bug fix
  • [ ] refactor - Code restructuring without behavior change
  • [ ] perf - Performance improvement
  • [ ] docs - Documentation update
  • [ ] test - Test-related changes
  • [ ] chore - Maintenance/tooling

Risk Level

  • [x] Low - Minor changes, limited scope
  • [ ] Medium - Moderate changes, some user impact
  • [ ] High - Major changes, significant user/system impact

What & Why

Adds the following initialization steps at end of 'Create new project' flow:

  • Prompts for azure connector details
  • Starts design-time host for the new project

Impact of Change

  • Users: Fixes incongruency between 'Create new workspace' and 'Create new project' where the latter doesn't immediately get azure connector details or start design-time
  • Developers: N/A
  • System: N/A

Test Plan

  • [ ] Unit tests added/updated
  • [ ] E2E tests added/updated
  • [x] Manual testing completed
  • [ ] Tested in:

Contributors

@andrew-eldridge

andrew-eldridge avatar Nov 21 '25 19:11 andrew-eldridge

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vscode): Prompt for azure connector details and start design-time host on new projects
  • Issue: None. The title is clear, scoped, and describes both the context (VSCode) and the change.
  • Recommendation: No changes needed. Good job!

Commit Type

  • Properly selected (fix)
  • Only one selected, which is correct

Risk Level

  • Selected risk is Low, confirmed by label "Risk:Low" and matches the scope of the change (just adding prompts and host startup after project create; no deep architectural impact or API change).

What & Why

  • Current: Adds the following initialization steps at end of 'Create new project' flow:
  • Prompts for azure connector details
  • Starts design-time host for the new project
  • Issue: None. Content is concise and directly describes the change and motivation.
  • Recommendation: No changes needed.

Impact of Change

  • Clearly identifies impact for users (brings new project flow in line with workspace creation). Developers and System marked N/A, which is reasonable for such a UI flow fix.
  • Recommendation: No changes needed.
    • Users: Clear improvement in workflow consistency
    • Developers: N/A is acceptable
    • System: N/A is acceptable

Test Plan

  • Manual testing completed and clearly indicated (checkbox marked)
  • For this type of UI behavior change, manual testing is appropriate. No issues.

Contributors

  • Only author listed, which is fine. No required contributors.
  • If any major idea or design input from others, consider tagging them in future.

Screenshots/Videos

  • Not strictly required for non-visual UI flow. No failure here. You may add visual evidence for usability changes for reviewer convenience, but not mandatory.

Summary Table

Section Status Recommendation
Title None
Commit Type None
Risk Level None
What & Why None
Impact of Change None
Test Plan None
Contributors None
Screenshots/Videos None

All required template sections are present and appropriate, risk level is correctly set, and the PR is compliant with process documentation. Well done!


Last updated: Fri, 21 Nov 2025 19:39:53 GMT

github-actions[bot] avatar Nov 21 '25 19:11 github-actions[bot]

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vscode): Prompt for azure connector details and start design-time host on new projects
  • Issue: Title is specific, includes area affected, nature of fix, and scope
  • Recommendation: None needed. This is an ideal PR title.

Commit Type

  • Properly selected (fix)
  • Only one selected, which is correct

Risk Level

  • Risk level "Low" is selected. PR is labeled "Risk:Low", and based on the code change (small, targeted, 7 additions, no deletions, scope limited to initialization after project creation), this is appropriate.

What & Why

  • Current: Adds the following initialization steps at end of 'Create new project' flow:
  • Prompts for azure connector details
  • Starts design-time host for the new project
  • Issue: Clear, brief, describes what was changed and why (adds missing initialization step).
  • Recommendation: None needed.

Impact of Change

  • Clear indication of impact to users (addressing missing initialization after project creation), developers (N/A), and system (N/A).
  • Recommendation: Users: Clear
    • Developers: N/A, but could explicitly state if there are any expected developer-facing changes or workflow impact (optional)
    • System: N/A, but if system behavior changes (dependencies, broader impact), mention (optional)

Test Plan

  • "Manual testing completed" is checked, which is common for small workflow fixes. No unit/E2E test required for a simple UX fix.

Contributors

  • @andrew-eldridge listed
  • Minimal, but if more contributors (PM, Design) helped, tagging them is appreciated (optional)

Screenshots/Videos

  • Not needed for backend/initialization workflow change. Section left blank, this passes.

Summary Table

Section Status Recommendation
Title None
Commit Type None
Risk Level None
What & Why None
Impact of Change None
Test Plan None
Contributors Optional: Tag PMs/designers if they contributed
Screenshots/Videos None

The PR passes all body and title checks, and the risk level is correct. No changes required. Thank you for maintaining clear, concise documentation in your PR!


Last updated: Fri, 21 Nov 2025 19:38:41 GMT

github-actions[bot] avatar Nov 21 '25 19:11 github-actions[bot]