LogicAppsUX icon indicating copy to clipboard operation
LogicAppsUX copied to clipboard

VS Code extension makes use of user settings to write workspace settings

Open mindingdata opened this issue 1 year ago • 1 comments

Describe the Bug with repro steps

I wrote down the majority of the issue over in the LogicApps repo here : https://github.com/Azure/logicapps/issues/1183

But I noticed this has the actual code for the extension so I'll keep it short here.

  • In many cases, the Logic Apps (Standard) VS Code extension writes settings to the workspace settings file
  • Workspace settings are shared between developers and checked into source control (As opposed to User Settings for example)
  • The settings that are being written are specific to a user (e.g. File paths utilizing the User folder).

e.x.

"terminal.integrated.env.windows": {
      "PATH": "C:\\Users\\MyName\\.azurelogicapps\\dependencies\\DotNetSDK;${env:PATH}"
  }

I'm not familiar with VS Code extension but I can see this for example here : https://github.com/Azure/LogicAppsUX/blob/7864f5d4416966c76ef8958a9986c265a54db3de/apps/vs-code-designer/src/app/commands/binaries/validateAndInstallBinaries.ts#L46

Which then calls the UpdateGlobalSetting method here : https://github.com/Azure/LogicAppsUX/blob/7864f5d4416966c76ef8958a9986c265a54db3de/apps/vs-code-designer/src/app/utils/vsCodeConfig/settings.ts#L34

This always updates the workspace settings. It would be much more helpful for these to be written to the user settings at the very least.

What type of Logic App Is this happening in?

Standard (VSCode)

Which operating system are you using?

Windows

Are you using new designer or old designer

New Designer

Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg

Yes

Workflow JSON

No response

Screenshots or Videos

No response

Browser

VS Code

Additional context

No response

mindingdata avatar Oct 16 '24 02:10 mindingdata

Any update on this?

TWolversonReply avatar Sep 13 '25 16:09 TWolversonReply