LogicAppsUX icon indicating copy to clipboard operation
LogicAppsUX copied to clipboard

Can't save Notes (Comments) in VS Code

Open kewear opened this issue 1 year ago • 1 comments

Describe the Bug with repro steps

See video below

What type of Logic App Is this happening in?

Standard (VSCode)

Are you using new designer or old designer

New Designer

Did you refer to the TSG before filing this issue? https://aka.ms/lauxtsg

No

Workflow JSON

No response

Screenshots or Videos

https://github.com/user-attachments/assets/605c6c91-5ec4-40cb-81f5-861cfe6fd29d

Browser

NA

Additional context

No response

kewear avatar Jul 19 '24 19:07 kewear

Update: I have found that I did have an invalid connection during this time. I was using Managed Identity (while in VS Code). After I change it to key, it does look like I can save. But regardless, not sure why a connection would have an impact on a note being added to workflow definition

kewear avatar Jul 19 '24 19:07 kewear

@kewear I have similar issues today with not being able to save comments (well, sometimes it works) in VS Code using the designer. We also use Managed Identity which I hope most use for better security. For me the comment is sometimes saved, sometimes not, and sometimes it's being chopped of, very random behaviour. I looked in the worklow.json and sure the description is indeed saved... sometimes.

Version of Azure Logic Apps (Standard) 4.107.3

MrRosendahl avatar Nov 07 '24 14:11 MrRosendahl

@kewear I have similar issues today with not being able to save comments (well, sometimes it works) in VS Code using the designer. We also use Managed Identity which I hope most use for better security. For me the comment is sometimes saved, sometimes not, and sometimes it's being chopped of, very random behaviour. I looked in the worklow.json and sure the description is indeed saved... sometimes.

Version of Azure Logic Apps (Standard) 4.107.3

Ok thanks @MrRosendahl tagging @ccastrotrejo for awareness

kewear avatar Nov 07 '24 15:11 kewear

Hi @MrRosendahl @kewear As for now we don't support connections using Managed Identity while in VS Code. When the user clicks the save button, we save parameters, connections, settings and workflow schema all at the same time. Therefore when you are trying to save this doesn't work properly as the connections have some errors. As a workaround could you pleas use a different type of connection? I will take this task for later and update the errors button in the command bar so it shows whenever these type of things happen

ccastrotrejo avatar Nov 07 '24 16:11 ccastrotrejo

Hi @MrRosendahl @kewear As for now we don't support connections using Managed Identity while in VS Code. When the user clicks the save button, we save parameters, connections, settings and workflow schema all at the same time. Therefore when you are trying to save this doesn't work properly as the connections have some errors. As a workaround could you pleas use a different type of connection? I will take this task for later and update the errors button in the command bar so it shows whenever these type of things happen

@ccastrotrejo, ah, yes I forgot to say that we use connectionstrings locally (we swap the files in deploy)... keep reading...

But, with a completely fresh workspace without any connections the comment bug is also present.

Logic Apps Standard extension 4.107.4 Steps to reproduce:

  1. CTRL-SHIFT-P select Azure Logic Apps: Create new logic app workspace...
  2. Folow the steps, i.e. select a local folder, enter a workspace name, logic app with custom code, select .net framework, enter a function name, enter a namespace name, choose stateful, use default name Stateful1, select open in current window. I do not think the options hace that much with the bug, I tested with others selections too with the comment bug result present.
  3. Build the Function.
  4. Open the workflow.json in the designer
  5. Add a note to the http request
  6. Save = The note is gone

MrRosendahl avatar Nov 21 '24 14:11 MrRosendahl

Adding two videos also.

https://github.com/user-attachments/assets/8d4f6a8e-4e04-47b7-be29-c2aea47de0a4 https://github.com/user-attachments/assets/33490e5b-a080-4d1d-9b56-2afb5044b58e

MrRosendahl avatar Nov 21 '24 15:11 MrRosendahl