Azure
Fix PowerShell profile casing
The powershell profile folders have incorrect casing (PowerShell instead of powershell) to the powershell default, and cause problems with scripts that interact with them. This PR fixes the casing.
Related Discussion: https://github.com/Azure/CloudShell/discussions/302
@JustinGrote - thank you for this pr. Hey Justin - @bhavanakonchada and I are reviewing the change - Justin, can you change the conditional to the following logic?
If lowercase only exists - do nothing If Pascal case only exists - rename to lowercase and add symlink PowerShell -> powershell If both cases exists - do nothing since fix is already in
@JustinGrote - thank you for this pr. Hey Justin - @bhavanakonchada and I are reviewing the change - Justin, can you change the conditional to the following logic?
If lowercase only exists - do nothing If Pascal case only exists - rename to lowercase and add symlink PowerShell -> powershell If both cases exists - do nothing since fix is already in
Adding to what @theJasonHelmick said, we need this change to avoid any disruption for existing customers as a lot could be riding on this path.
@bhavanakonchada @theJasonHelmick I added migration logic as appropriate and tried to handle all possible edge cases, I did not do this transparently as users should be informed what is going on.
Thank you @JustinGrote - much appreciated. Will review with @bhavanakonchada with the plan to accept the PR after testing.
Thank you @JustinGrote - much appreciated. Will review with @bhavanakonchada with the plan to accept the PR after testing.
I've delayed the review and merge of the PR to October 2023 post feature release for Ephemeral and UX2. Thank you for this fix - looking forward to have it included soon. WE may need to adjust the code for our own purposes, but the credit goes to you @JustinGrote for the catch and code. Thank you!