Azure-Sentinel icon indicating copy to clipboard operation
Azure-Sentinel copied to clipboard

CEF-AMA Setup

Open Cyberlorians opened this issue 2 years ago • 8 comments

Required items, please complete

Change(s):

  • See guidance below

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

  • New schema used for XYZ.yaml
  • Resolves ISSUE #1234

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally. https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


Cyberlorians avatar Jan 15 '24 14:01 Cyberlorians

Hello @Cyberlorians, Please try to resolve validation errors. Also if this is an function app its missing with function app and azure deploy file. Please follow this folder structure and files required DataConnectors/AWS-SecurityHubFindings

v-prasadboke avatar Jan 16 '24 09:01 v-prasadboke

Hello @Cyberlorians, Please try to resolve validation errors. Also if this is an function app its missing with function app and azure deploy file. Please follow this folder structure and files required DataConnectors/AWS-SecurityHubFindings

There is no function app. This builds upon the current CEF install that is published. We wrote an article on how to install CEF-AMA in Azure Public and Government. I am still hosting the gov.py script on my own GIT. I would like if MSFT would take this and make it published (own). I have no clue how to do any of this. If @Sreedhande wants to take ownership of this, great. 

Articles/CEF-AMASetup.md at main · Cyberlorians/Articles (github.com)

Cyberlorians avatar Jan 16 '24 13:01 Cyberlorians

Asked Sreedhar to take a look at this.

v-prasadboke avatar Jan 18 '24 06:01 v-prasadboke

Hello @Cyberlorians, Code Ql is throwing error Too many parameters for special method __repr__, which has 2 parameters, but should have 1, in class Please let me know if its ok, else please fix it.

v-prasadboke avatar Jan 30 '24 06:01 v-prasadboke

Hello @Cyberlorians, can you please check once Codel QL error.

v-prasadboke avatar Feb 01 '24 08:02 v-prasadboke

Hello @Cyberlorians, Please go through the Code QL error once

v-prasadboke avatar Feb 05 '24 10:02 v-prasadboke

Hello @Cyberlorians, We know you might be busy onto something. Just wanted to know if you have some updates on the above mentioned comments.

v-prasadboke avatar Feb 07 '24 05:02 v-prasadboke

No sorry I haven’t. I don’t understand what to fix because it’s actual code that needs to be there. Sreedhar was supposed to take this over and work on it, I think. Has he?

Get Outlook for iOShttps://aka.ms/o0ukef


From: v-prasadboke @.> Sent: Wednesday, February 7, 2024 12:10:28 AM To: Azure/Azure-Sentinel @.> Cc: Cyberlorians @.>; Mention @.> Subject: Re: [Azure/Azure-Sentinel] CEF-AMA Setup (PR #9764)

Hello @Cyberlorianshttps://github.com/Cyberlorians, We know you might be busy onto something. Just wanted to know if you have some updates on the above mentioned comments.

— Reply to this email directly, view it on GitHubhttps://github.com/Azure/Azure-Sentinel/pull/9764#issuecomment-1931295699, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOZFFNFZCVOLPLGOKEINZJ3YSMEEJAVCNFSM6AAAAABB3NDFUWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZRGI4TKNRZHE. You are receiving this because you were mentioned.Message ID: @.***>

Cyberlorians avatar Feb 07 '24 11:02 Cyberlorians