Azure-Sentinel
Azure-Sentinel copied to clipboard
Entity Work Jan 4 - Manny
Required items, please complete
Change(s):
- Working on some of the detections Shain asked us to focus on, mainly adding fullName identifiers
Reason for Change(s):
- Changes needed listed on Shain's dashboard
Version Updated:
- yes
Testing Completed:
- yes
Checked that the validations are passing and have addressed any issues that are present:
- no
Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version
property of the template you changed.
Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version
property of the template you changed.
Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version
property of the template you changed.
Hello @mmelndezlujn, Shain has requested some changes please take a look at it
Hello @mmelndezlujn, Shain has some requested changes. Kindly please have a look at it. Thanks
Hello @mmelndezlujn, Can you provide write access to your branch. I'll try to resolve validation errors.
Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version
property of the template you changed.
Hello @mmelndezlujn, Can you provide write access to your branch. I'll try to resolve validation errors.
Hello @v-prasadboke, I am not sure if I can provide write access as I am not the repo owner.
@shainw could you help me with this, please? :)
Hello @mmelndezlujn, Can you provide write access to your branch. I'll try to resolve validation errors.
Hello @v-prasadboke, I am not sure if I can provide write access as I am not the repo owner.
@shainw could you help me with this, please? :)
Hi @shainw, Any help on this.
Hello @mmelndezlujn, can you update the branch from master
Hello @mmelndezlujn, can you update the branch from master
done :)
Hello @mmelndezlujn, Sorry but I dont see the branch updated from master
Hello how are you I am GitHub bot
😀😀
I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed?
If not, and if you want customers to be aware that a new version of this template is available, please update the version
property of the template you changed.
Hello @mmelndezlujn, Sorry but I dont see the branch updated from master
My bad, I hadn't pushed it, but it's updated now
Hello @mmelndezlujn, Can you provide write access to your branch. I'll try to resolve validation errors.
Hello @v-prasadboke, I am not sure if I can provide write access as I am not the repo owner. @shainw could you help me with this, please? :)
Hi @shainw, Any help on this.
@v-prasadboke and @mmelndezlujn - We are not going to complete this PR. There are too many file changes in one PR and there are more changes that are needed based on my comments. I am going to take the changes and break them down into 5-6 file submissions and extend the mappings I called out as needed. I am closing this and will reference this in the new PRs.