Azure-Sentinel icon indicating copy to clipboard operation
Azure-Sentinel copied to clipboard

Entity Work Jan 4 - Manny

Open mmelndezlujn opened this issue 1 year ago • 5 comments

Required items, please complete

Change(s):

  • Working on some of the detections Shain asked us to focus on, mainly adding fullName identifiers

Reason for Change(s):

  • Changes needed listed on Shain's dashboard

Version Updated:

  • yes

Testing Completed:

  • yes

Checked that the validations are passing and have addressed any issues that are present:

  • no

mmelndezlujn avatar Jan 04 '24 19:01 mmelndezlujn

Hello how are you I am GitHub bot 😀😀 I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed? If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

github-actions[bot] avatar Jan 04 '24 19:01 github-actions[bot]

Hello how are you I am GitHub bot 😀😀 I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed? If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

github-actions[bot] avatar Jan 05 '24 00:01 github-actions[bot]

Hello how are you I am GitHub bot 😀😀 I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed? If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

github-actions[bot] avatar Jan 05 '24 00:01 github-actions[bot]

Hello @mmelndezlujn, Shain has requested some changes please take a look at it

v-prasadboke avatar Feb 13 '24 08:02 v-prasadboke

Hello @mmelndezlujn, Shain has some requested changes. Kindly please have a look at it. Thanks

v-prasadboke avatar Feb 16 '24 06:02 v-prasadboke

Hello @mmelndezlujn, Can you provide write access to your branch. I'll try to resolve validation errors.

v-prasadboke avatar Feb 22 '24 05:02 v-prasadboke

Hello how are you I am GitHub bot 😀😀 I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed? If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

Hello @mmelndezlujn, Can you provide write access to your branch. I'll try to resolve validation errors.

Hello @v-prasadboke, I am not sure if I can provide write access as I am not the repo owner.

@shainw could you help me with this, please? :)

mmelndezlujn avatar Feb 22 '24 20:02 mmelndezlujn

Hello @mmelndezlujn, Can you provide write access to your branch. I'll try to resolve validation errors.

Hello @v-prasadboke, I am not sure if I can provide write access as I am not the repo owner.

@shainw could you help me with this, please? :)

Hi @shainw, Any help on this.

v-prasadboke avatar Feb 26 '24 11:02 v-prasadboke

Hello @mmelndezlujn, can you update the branch from master

v-prasadboke avatar Mar 08 '24 09:03 v-prasadboke

Hello @mmelndezlujn, can you update the branch from master

done :)

mmelndezlujn avatar Mar 11 '24 21:03 mmelndezlujn

Hello @mmelndezlujn, Sorry but I dont see the branch updated from master

v-prasadboke avatar Mar 12 '24 13:03 v-prasadboke

Hello how are you I am GitHub bot 😀😀 I see that you changed templates under the detections/analytic rules folder. Did you remember to update the version of the templates you changed? If not, and if you want customers to be aware that a new version of this template is available, please update the version property of the template you changed.

Hello @mmelndezlujn, Sorry but I dont see the branch updated from master

My bad, I hadn't pushed it, but it's updated now

mmelndezlujn avatar Mar 12 '24 14:03 mmelndezlujn

Hello @mmelndezlujn, Can you provide write access to your branch. I'll try to resolve validation errors.

Hello @v-prasadboke, I am not sure if I can provide write access as I am not the repo owner. @shainw could you help me with this, please? :)

Hi @shainw, Any help on this.

@v-prasadboke and @mmelndezlujn - We are not going to complete this PR. There are too many file changes in one PR and there are more changes that are needed based on my comments. I am going to take the changes and break them down into 5-6 file submissions and extend the mappings I called out as needed. I am closing this and will reference this in the new PRs.

shainw avatar Mar 13 '24 00:03 shainw