Azure-Sentinel icon indicating copy to clipboard operation
Azure-Sentinel copied to clipboard

Users/v muuppugund/cloud data connector

Open v-muuppugund opened this issue 1 year ago • 2 comments

Required items, please complete

Change(s):

  • Standard tier is removed from Azure security center data connector as its obsolete

Reason for Change(s):

  • There is a GitHub issue (https://github.com/Azure/Azure-Sentinel/issues/9426)

Version Updated: -3.0.1

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

  • New schema used for XYZ.yaml
  • Resolves ISSUE #1234

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally. https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


v-muuppugund avatar Dec 21 '23 11:12 v-muuppugund

Hi @v-muuppugund, thank you for raising PR by adding changes, as discussed please add testing completed screenshot in PR itself. Thanks!

v-sudkharat avatar Jan 10 '24 06:01 v-sudkharat

@v-muuppugund, 1- Please update the release notes path in create ui file - image

2- Description for both the connector looks same, please check on it - image

  1. After deployment of solution the Tenant-based Microsoft Defender for Cloud (Preview) corrector is not redirecting connector instruction page- image

I have checked the data file and found that this connector is 1P - true - image

Please check on this. Thanks!

v-sudkharat avatar Jan 11 '24 12:01 v-sudkharat