Azure-Sentinel icon indicating copy to clipboard operation
Azure-Sentinel copied to clipboard

Added solution for Dataminr Pulse

Open jayeshprajapaticrest opened this issue 1 year ago • 7 comments

Required items, please complete

Change(s):

  • Added Dataminr Pulse solution for certification

Reason for Change(s):

  • New Product

Version Updated:

  • Initial Version

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

jayeshprajapaticrest avatar Apr 12 '23 14:04 jayeshprajapaticrest

Hello @jayeshprajapaticrest oshezaf have requested changes

v-prasadboke avatar Apr 18 '23 13:04 v-prasadboke

Hello @jayeshprajapaticrest oshezaf have requested changes

@v-prasadboke We have noted comment suggested by @oshezaf and we are working on it.

jayeshprajapaticrest avatar Apr 18 '23 14:04 jayeshprajapaticrest

Hello @jayeshprajapaticrest any updates on the above

v-prasadboke avatar Apr 25 '23 11:04 v-prasadboke

Hello @jayeshprajapaticrest Please remove the branch conflicts as well

v-prasadboke avatar Apr 27 '23 10:04 v-prasadboke

Hello @jayeshprajapaticrest Please remove the branch conflicts as well

@v-prasadboke Sure we will do it. Thanks

jayeshprajapaticrest avatar Apr 29 '23 10:04 jayeshprajapaticrest

Hello @jayeshprajapaticrest any updates on the above

v-prasadboke avatar May 03 '23 05:05 v-prasadboke

Hello @jayeshprajapaticrest any updates on the above

@v-prasadboke I have resolved the conflicts. Please confirm and let me know if anything else changes are required.

jayeshprajapaticrest avatar May 03 '23 12:05 jayeshprajapaticrest

Hello @oshezaf author has requested for review

v-prasadboke avatar May 05 '23 04:05 v-prasadboke

Hello @oshezaf any updates on the above

v-prasadboke avatar May 09 '23 11:05 v-prasadboke

The api version of Microsoft.Resources/templateSpecs/versions is 2021-05-01 please replace it with 2022-02-01. Please correct the api version and repackage the solution again.

v-prasadboke avatar May 16 '23 12:05 v-prasadboke

hello @jayeshprajapaticrest any updates

v-prasadboke avatar May 18 '23 16:05 v-prasadboke

The api version of Microsoft.Resources/templateSpecs/versions is 2021-05-01 please replace it with 2022-02-01. Please correct the api version and repackage the solution again.

@v-prasadboke I have updated API version and committed the updated solution.

jayeshprajapaticrest avatar May 23 '23 06:05 jayeshprajapaticrest

The api version of Microsoft.Resources/templateSpecs/versions is 2021-05-01 please replace it with 2022-02-01. Please correct the api version and repackage the solution again.

@v-prasadboke I have updated API version and committed the updated solution.

@v-prasadboke As we are done with the API version change is there any update on this PR for further process?

jayeshprajapaticrest avatar May 30 '23 05:05 jayeshprajapaticrest

@oshezaf As there is no specific schema available to map our dataminr alerts data. We have scrapped that use case of ASIM mapping and remove the related files from the PR.

jayeshprajapaticrest avatar Jun 07 '23 10:06 jayeshprajapaticrest

@v-atulyadav @devikamehra @v-prasadboke @manishkumar1991 @oshezaf @rahul0216 @manishkumar1991 Is there any updates on this PR?

jayeshprajapaticrest avatar Jun 15 '23 18:06 jayeshprajapaticrest

@jayeshprajapaticrest : Kindly share the playbook working screenshots

manishkumar1991 avatar Jun 19 '23 05:06 manishkumar1991

@Team While resolving conflicts don't know PR gets automatically closed.

jayeshprajapaticrest avatar Jul 04 '23 11:07 jayeshprajapaticrest

@jayeshprajapaticrest : Kindly share the playbook working screenshots @rahul0216 PFA for the same.

PlaybookDataminr

jayeshprajapaticrest avatar Jul 04 '23 11:07 jayeshprajapaticrest

Playbook looks good.

manishkumar1991 avatar Jul 07 '23 06:07 manishkumar1991

@v-atulyadav @devikamehra @v-prasadboke @manishkumar1991 @oshezaf @rahul0216 @manishkumar1991 Is there any updates on this PR?

@v-atulyadav @devikamehra @v-prasadboke @manishkumar1991 @oshezaf @rahul0216 @manishkumar1991 Is there any updates on this PR?

jayeshprajapaticrest avatar Jul 11 '23 06:07 jayeshprajapaticrest

Hello @jayeshprajapaticrest there is still one arm-ttk failure for the PR, please resolve it

v-prasadboke avatar Jul 11 '23 06:07 v-prasadboke

Hello @jayeshprajapaticrest there is still one arm-ttk failure for the PR, please resolve it

@v-prasadboke Working on it. Still getting the hard coded URL related validation error even if I used variable to get it from customer as input with default values.

jayeshprajapaticrest avatar Jul 13 '23 12:07 jayeshprajapaticrest

Ok @jayeshprajapaticrest will examine the validation failures, You can expect an update till 18 Jul

v-prasadboke avatar Jul 13 '23 12:07 v-prasadboke

Ok @jayeshprajapaticrest will examine the validation failures, You can expect an update till 18 Jul

OK. Thanks. Then should I commit updated solution created using V3 tool?

jayeshprajapaticrest avatar Jul 13 '23 12:07 jayeshprajapaticrest

Hello @jayeshprajapaticrest thanks for committing the changes, you can expect an update till 25 Jul 2023

v-prasadboke avatar Jul 20 '23 17:07 v-prasadboke

Hello @jayeshprajapaticrest, arm ttk is failing for hardcoded uri. As discussed in the call ill have this issue investigated within the team and Update you soon about the same.

v-prasadboke avatar Jul 24 '23 11:07 v-prasadboke

Hello @jayeshprajapaticrest, arm ttk is failing for hardcoded uri. As discussed in the call ill have this issue investigated within the team and Update you soon about the same.

Understood. Thanks

jayeshprajapaticrest avatar Jul 24 '23 13:07 jayeshprajapaticrest

@v-prasadboke Any updates on this PR?

jayeshprajapaticrest avatar Jul 26 '23 05:07 jayeshprajapaticrest

Hello @jayeshprajapaticrest can we have a quick call for this PR.

v-prasadboke avatar Jul 26 '23 07:07 v-prasadboke

Hello @jayeshprajapaticrest can we have a quick call for this PR.

If it takes less than 15 min than sure we can connect now. Please share the link.

jayeshprajapaticrest avatar Jul 26 '23 07:07 jayeshprajapaticrest