Azure-Sentinel icon indicating copy to clipboard operation
Azure-Sentinel copied to clipboard

Published 20 hours ago • verified publisher icon Azure

PDNS block data connector

Open TedWhi opened this issue 1 year ago • 12 comments

Required items, please complete

Change(s):

  • Added a new data connector to pull PDNS Block Data from Nominet's S3 bucket and post to Log Analytics

Reason for Change(s):

  • Would like to publish this data on the Azure Content Hub for Nominet's clients to download

Testing Completed:

  • Yes Checked that the validations are passing and have addressed any issues that are present:
  • Yes

Let me know if you need any more detail :))

TedWhi avatar Mar 30 '23 15:03 TedWhi

I see this has failed the Data Connector validations, the validator reports that it "could not identify a json file as a connector". I have created a custom data connector using an Azure Function and tested that it works. The connector is not defined in a single json file, rather as a function. I am confused as to what I need to do to make the validator happy here, would you be able to advise?

TedWhi avatar Mar 30 '23 15:03 TedWhi

Hi @TedWhi, please keep the text and other data related to permissions parameter in connector file exactly similar to the permissions configuration available in the REST-API Connector Template, this includes the positioning and indent of the brackets as well as the display text, if you require any further assistance please let me know, thanks!

v-vdixit avatar Mar 31 '23 06:03 v-vdixit

Thanks for the quick and clear response @v-vdixit !

TedWhi avatar Mar 31 '23 08:03 TedWhi

@microsoft-github-policy-service agree company="Nominet"

TedWhi avatar Mar 31 '23 16:03 TedWhi

Hi @TedWhi we are looking into this, will update shortly, thanks!

v-vdixit avatar Apr 04 '23 10:04 v-vdixit

Hi @TedWhi, we are still working on this, will update you shortly, thanks!

v-vdixit avatar Apr 10 '23 05:04 v-vdixit

Hi @TedWhi, we are working on this, thanks!

v-vdixit avatar Apr 12 '23 04:04 v-vdixit

we are working on this, thanks!

v-atulyadav avatar Apr 13 '23 15:04 v-atulyadav

Hi @TedWhi, we are testing the connector and other files, will update you shortly, thanks!

v-vdixit avatar Apr 18 '23 13:04 v-vdixit

Hi @TedWhi we are looking into this, thanks!

v-vdixit avatar Apr 25 '23 11:04 v-vdixit

Hi @TedWhi we are still working on this, thanks!

v-vdixit avatar Apr 27 '23 13:04 v-vdixit

Hi, we are working on this, thanks!

v-vdixit avatar May 02 '23 12:05 v-vdixit

We are still working on this, thanks!

v-vdixit avatar May 05 '23 04:05 v-vdixit

We are working on this, thanks!

v-vdixit avatar May 09 '23 12:05 v-vdixit

Hi, we are still working on this will update soon, thanks

v-vdixit avatar May 18 '23 12:05 v-vdixit

Hi @TedWhi can you please add screenshots demonstrating successful working of function app, please add screenshot for invocation logs too, if possible, thanks!

v-vdixit avatar Jun 05 '23 04:06 v-vdixit

Hi @TedWhi can you please add screenshots demonstrating successful working of function app, please add screenshot for invocation logs too, if possible, thanks!

Hi @TedWhi we are waiting for you update on this, thanks!

v-vdixit avatar Jun 15 '23 06:06 v-vdixit

Hi @TedWhi we are waiting for your update on this PR with screenshots demonstrating successful working of connector, thanks!

v-vdixit avatar Jun 21 '23 05:06 v-vdixit

Hi @TedWhi we are still waiting for your update on this, thanks!

v-vdixit avatar Jun 26 '23 05:06 v-vdixit

Hi @v-vdixit , sorry for the delayed response. I'm very busy at the moment. I should be able to update on Friday

TedWhi avatar Jun 26 '23 08:06 TedWhi

Hi @v-vdixit , sorry for the delayed response. I'm very busy at the moment. I should be able to update on Friday

Hi @TedWhi we are waiting for your update on this, thanks!

v-vdixit avatar Jul 04 '23 13:07 v-vdixit

Hi @TedWhi, waiting for your response. Thanks

v-atulyadav avatar Jul 07 '23 03:07 v-atulyadav

@v-vdixit . Apologies for the delay, please see below screenshots of data ingested into log analytics. The resources as deployed. And evidence of the function running correctly. Let me know if there's anything else you need.

image image image

TedWhi avatar Jul 07 '23 08:07 TedWhi

The above screenshots are of a new version of the connector I have been working on. I will upload those changes shortly.

TedWhi avatar Jul 07 '23 09:07 TedWhi

Hi @TedWhi thanks for providing the screenshots, please let us know once you have updated the changes, thanks!

v-vdixit avatar Jul 11 '23 06:07 v-vdixit

Hi @v-vdixit. Once again, sorry for the delay. I have pushed the changes!

TedWhi avatar Jul 12 '23 13:07 TedWhi

Thanks for the update @TedWhi we will check on the other code changes and update you by Friday, 21st July 2023.

v-vdixit avatar Jul 13 '23 10:07 v-vdixit

Hi @TedWhi we are reviewing data connector changes in this PR, will provide update by 24 Jul 2023, thanks!

v-vdixit avatar Jul 21 '23 11:07 v-vdixit

Hello @TedWhi, please be consistent with the use of bold text in the instruction stages. We can see Step 1 can be seen in the following format. image

v-sudkharat avatar Jul 26 '23 10:07 v-sudkharat

Hi @TedWhi, hope you are doing well. Just wanted to check if you got a chance to look at the suggestions shared. Please feel free to reach out to us for any queries or support.

v-sudkharat avatar Jul 28 '23 10:07 v-sudkharat