Azure-Sentinel icon indicating copy to clipboard operation
Azure-Sentinel copied to clipboard

Update ReversingLabs solution to v2.0.1

Open AaronHoffmannRL opened this issue 2 years ago • 4 comments

Required items, please complete

Change(s):

  • Updates workbook "ReversingLabs-CapabilitiesOverview": update KQL queries in workbook to match playbook names as deployed by solution; update guide text

Reason for Change(s):

  • Typo in workbook query would prevent data from being properly displayed

Version Updated:

  • N/A

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Yes

AaronHoffmannRL avatar Jan 03 '23 20:01 AaronHoffmannRL

@AaronHoffmannRL : Please increment the version of the workbook in workbookmetadata.json(\Tools\Create-Azure-Sentinel-Solution\V2\WorkbookMetadata) file. Workbook looks fine image Once done the above change we will proceed to approve.

v-spadarthi avatar Jan 06 '23 05:01 v-spadarthi

@v-spadarthi done, version has been updated

AaronHoffmannRL avatar Jan 06 '23 16:01 AaronHoffmannRL

Hi @AaronHoffmannRL, Thanks for making the requested changes will review and share the feedback. Thanks

v-mchatla avatar Jan 11 '23 04:01 v-mchatla

Hi @AaronHoffmannRL, I will review the changes today and share the feedback. Thanks

v-mchatla avatar Jan 13 '23 03:01 v-mchatla

@v-mchatla any updates?

AaronHoffmannRL avatar Jan 19 '23 15:01 AaronHoffmannRL

@v-mchatla any updates?

Hi @AaronHoffmannRL, Sorry for the delay. I have reviewed the content everything looks good except the filenames for the preview images. Please be consistent with the filename conventions - the dark theme filename should contain the word "black" and the light theme image should contain the word "white". You can refer the existing filename conventions from here. Thanks

v-mchatla avatar Jan 20 '23 07:01 v-mchatla

@v-mchatla thanks for the updates - I've updated the image files as requested

AaronHoffmannRL avatar Jan 20 '23 19:01 AaronHoffmannRL

Hi @AaronHoffmannRL, Sorry for multiple requests, I just found that logo file is missing under Images folder please follow this structure (Workbooks/Images/Logo) to add your logo file. No need to update anything in the metadata file for this. Thanks

v-mchatla avatar Jan 23 '23 12:01 v-mchatla

@v-mchatla no worries, I've added the logo file

AaronHoffmannRL avatar Jan 23 '23 19:01 AaronHoffmannRL