Azure-Sentinel
Azure-Sentinel copied to clipboard
Azure
Add files via upload
Required items, please complete
Change(s):
- See guidance below
Reason for Change(s):
- See guidance below
Version Updated:
- Required only for Detections/Analytic Rule templates
- See guidance below
Testing Completed:
- See guidance below
Checked that the validations are passing and have addressed any issues that are present:
- See guidance below
Guidance <- remove section before submitting
Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:
Thank you for your contribution to the Microsoft Sentinel Github repo.
Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.
Change(s):
- Updated syntax for XYZ.yaml
Reason for Change(s):
- New schema used for XYZ.yaml
- Resolves ISSUE #1234
Version updated:
- Yes
- Detections/Analytic Rule templates are required to have the version updated
The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.
Testing Completed:
- Yes/No/Need Help
Note: If updating a detection, you must update the version field.
Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally. https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally
Checked that the validations are passing and have addressed any issues that are present:
- Yes/No/Need Help
Note: Let us know if you have tried fixing the validation error and need help.
References:
@manishkumar1991 : Please review the Playbook and provide your approval. Thanks!
@manishkumar1991 : Please review the Playbook and provide your approval. Thanks!
@manishkumar1991 : Please review the Playbook and provide your approval. Thanks!
Hi @lior-tamir, we still waiting for your response on above comment's. Thanks
Hi @lior-tamir, we wanted to check on the status of PR #<6971>. PR is pending for more than 30 days. Please let us know if you need any assistance to review this PR. Per our standard operating procedures if no response is received in the next 7 business days, we will close this PR. Thank you for your cooperation
Hi @lior-tamir, we wanted to check on the status of PR #https://github.com/Azure/Azure-Sentinel/pull/6971. PR is pending for more than 32 days. Please let us know if you need any assistance to review this PR. Per our standard operating procedures if no response is received in the next 7 business days, we will close this PR. Thank you for your cooperation
@v-atulyadav , I've made the suggested changes. @manishkumar1991 @anki-narravula Please review the updates.
Hi, Lior is not part of the org anymore. Is there anything that I can do instead so that it is merged?
Hi @manishkumar1991 @anki-narravula, could you please review the updated. Thanks.
Hi @manishkumar1991 @anki-narravula, could you please review the updated. Thanks.
I am reviewing it.
Hi @BenjiSec, please check with Contributor License Agreement(CLA). Thanks.
Closed this as this branch was owned by Lior and he has left the org so creating this duplicate PR#(https://github.com/Azure/Azure-Sentinel/pull/7497)