Azure-Sentinel icon indicating copy to clipboard operation
Azure-Sentinel copied to clipboard

090122 as ip blocklist

Open AcceleryntSecurityDev opened this issue 2 years ago • 13 comments

 Change(s):
  • New playbook

Reason for Change(s):

  • New playbook

Testing Completed:

  • Yes

AcceleryntSecurityDev avatar Sep 02 '22 19:09 AcceleryntSecurityDev

@devikamehra and @rushriva : Please review the playbooks and provide your comments. Thanks!!

v-spadarthi avatar Sep 08 '22 10:09 v-spadarthi

@devikamehra @rushriva @v-spadarthi : Hello all, I just wanted to follow up with this. Has anyone had a chance to review?

hollyollyoxenfree avatar Sep 13 '22 18:09 hollyollyoxenfree

Hi @devikamehra and @rushriva : Can you please review the playbooks and provide your feedback accordingly?. Thanks!!

v-atulyadav avatar Sep 16 '22 05:09 v-atulyadav

Hi @devikamehra and @rushriva : Can you please review the playbooks and provide your feedback accordingly?. Thanks!!

v-atulyadav avatar Sep 20 '22 06:09 v-atulyadav

@devikamehra @rushriva @v-spadarthi there was some missing documentation and code for using the Azure Key Vault for storing secrets. My most recent commits have fixed these issues.

AcceleryntSecurityDev avatar Sep 20 '22 23:09 AcceleryntSecurityDev

Hi @rushriva @devikamehra , @AcceleryntSecurityDev has fixed some issues can you please review and provide feedback accordingly. Thanks.

v-atulyadav avatar Sep 22 '22 14:09 v-atulyadav

Hi @rushriva @devikamehra , @AcceleryntSecurityDev has fixed some issues can you please review and provide feedback accordingly. Thanks.

v-atulyadav avatar Sep 27 '22 12:09 v-atulyadav

@v-atulyadav @devikamehra @rushriva - I have updated the azuredeploy.json file per your comments about new requirements on my other PRs

AcceleryntSecurityDev avatar Sep 29 '22 19:09 AcceleryntSecurityDev

Hi @rushriva @devikamehra , @AcceleryntSecurityDev has made some changes can you please review and provide feedback accordingly. Thanks.

v-atulyadav avatar Oct 03 '22 17:10 v-atulyadav

Hi @rushriva @devikamehra , @AcceleryntSecurityDev has made some changes can you please review and provide feedback accordingly. Thanks.

v-atulyadav avatar Oct 06 '22 11:10 v-atulyadav

Hi @rushriva @devikamehra , @AcceleryntSecurityDev has made some changes 10 days ago can you please check those changes. Thanks.

v-atulyadav avatar Oct 10 '22 03:10 v-atulyadav

Hi @rushriva @devikamehra , @AcceleryntSecurityDev made some changes twelve days ago, so please check them. Thanks.

v-atulyadav avatar Oct 12 '22 04:10 v-atulyadav

Hi @rushriva @devikamehra , please check the changes made by @AcceleryntSecurityDev few days ago. Thanks.

v-atulyadav avatar Oct 14 '22 04:10 v-atulyadav

Hi @rushriva @devikamehra , @AcceleryntSecurityDev has made some changes can you please review and provide feedback accordingly. Thanks.

v-atulyadav avatar Oct 18 '22 08:10 v-atulyadav

Hi @rushriva @devikamehra , @AcceleryntSecurityDev made a few changes almost 21 days ago, so please check them out

v-atulyadav avatar Oct 21 '22 04:10 v-atulyadav

Hi @rushriva @devikamehra , @AcceleryntSecurityDev has made some changes can you please review and provide feedback accordingly. Thanks.

v-atulyadav avatar Oct 25 '22 07:10 v-atulyadav

Hi @rushriva @devikamehra , @AcceleryntSecurityDev has made some changes can you please review.Thanks

v-atulyadav avatar Oct 28 '22 04:10 v-atulyadav

Hi @rushriva @devikamehra , @AcceleryntSecurityDev has made some changes can you please review and provide feedback accordingly. Thanks.

v-atulyadav avatar Oct 31 '22 07:10 v-atulyadav

Hi @rushriva and @devikamehra , @AcceleryntSecurityDev has made some changes can you please review and provide feedback accordingly. Thanks.

v-spadarthi avatar Nov 02 '22 05:11 v-spadarthi

Hi @rushriva @devikamehra , @AcceleryntSecurityDev made some changes twelve days ago, so please check them. Thanks.

v-atulyadav avatar Nov 04 '22 05:11 v-atulyadav

Hi @rushriva @devikamehra , @AcceleryntSecurityDev has made some changes can you please review.Thanks

v-atulyadav avatar Nov 08 '22 10:11 v-atulyadav

Hi @rushriva @devikamehra , @AcceleryntSecurityDev has made some changes can you please review.Thanks

v-spadarthi avatar Nov 11 '22 05:11 v-spadarthi

@AcceleryntSecurityDev :

Endpoint call for fetching the named list ID's is failing ,,, Kindly check and respond

image

@manishkumar1991 I was unable to replicate. I tested the logic app again as well and all appears to be working. image

hollyollyoxenfree avatar Nov 15 '22 20:11 hollyollyoxenfree

Hi @AcceleryntSecurityDev, could you please respond to the comment above?

v-atulyadav avatar Nov 18 '22 02:11 v-atulyadav

@v-atulyadav @manishkumar1991 I was unable to replicate Manish's issue. I tested the logic app again as well and all appears to be working. image

AcceleryntSecurityDev avatar Nov 18 '22 02:11 AcceleryntSecurityDev

@v-atulyadav @manishkumar1991 I was unable to replicate Manish's issue. I tested the logic app again as well and all appears to be working. image

I will check on this again

manishkumar1991 avatar Nov 21 '22 07:11 manishkumar1991

@AcceleryntSecurityDev ,

I have again gone through the readme steps you mentioned,

I have created the name location list image

then i have followed the highlighted steps image

which is failing for me, Can you please double check if you forget to mention any details on readme file which needs to be done before doing this step

manishkumar1991 avatar Nov 21 '22 08:11 manishkumar1991

Hi @AcceleryntSecurityDev, please check and respond to Manish's comments. Thanks.

v-atulyadav avatar Nov 25 '22 04:11 v-atulyadav

@manishkumar1991 It may be that this request is failing through Microsoft Graph if you are signed in with a personal account rather than a work account. Could this be the issue? I haven't been able to find any other prerequisites that could be associated with your error. https://learn.microsoft.com/en-us/graph/api/conditionalaccessroot-list-namedlocations?view=graph-rest-1.0&tabs=http image

AcceleryntSecurityDev avatar Nov 29 '22 06:11 AcceleryntSecurityDev

@manishkumar1991 It may be that this request is failing through Microsoft Graph if you are signed in with a personal account rather than a work account. Could this be the issue? I haven't been able to find any other prerequisites that could be associated with your error. https://learn.microsoft.com/en-us/graph/api/conditionalaccessroot-list-namedlocations?view=graph-rest-1.0&tabs=http image

Will check internally and respond back

manishkumar1991 avatar Nov 30 '22 05:11 manishkumar1991