Azure-Sentinel icon indicating copy to clipboard operation
Azure-Sentinel copied to clipboard

Cloudformation template for AWS S3 connector

Open chrisjaimon2012 opened this issue 2 years ago • 14 comments

chrisjaimon2012 avatar Jul 19 '22 04:07 chrisjaimon2012

CLA assistant check
All CLA requirements met.

@chrisjaimon2012 : Please fix the validation errors and data connector file should not be a .YAML file. Could you please refer the below URL for data connector templates and do the necessary changes if required. https://github.com/Azure/Azure-Sentinel/tree/master/DataConnectors/Templates

v-spadarthi avatar Aug 05 '22 10:08 v-spadarthi

@chrisjaimon2012 : Please fix the validation errors and data connector file should not be a .YAML file. Could you please refer the below URL for data connector templates and do the necessary changes if required. https://github.com/Azure/Azure-Sentinel/tree/master/DataConnectors/Templates

hey @v-spadarthi , the PR consists of a Cloudformation template that deploys the necessary components for the AWS-S3 data connector, similar to the Powershell scripts that achieves the same. Its not a new connector.

chrisjaimon2012 avatar Aug 06 '22 06:08 chrisjaimon2012

@v-spadarthi Please look into this.

NikTripathi avatar Sep 08 '22 19:09 NikTripathi

Checking with CAT team to proceed further

v-spadarthi avatar Sep 20 '22 14:09 v-spadarthi

Waiting for the update from CAT team to proceed further

v-spadarthi avatar Sep 23 '22 04:09 v-spadarthi

@chrisjaimon2012 Can you please provide brief description of what your template does and how do you think this can help the existing connector? Does this add a missing piece, or it is simply another way of creating the same connector?

devikamehra avatar Sep 24 '22 05:09 devikamehra

@chrisjaimon2012 Can you please provide brief description of what your template does and how do you think this can help the existing connector? Does this add a missing piece, or it is simply another way of creating the same connector? Thanks

v-spadarthi avatar Sep 27 '22 05:09 v-spadarthi

@chrisjaimon2012 Can you please provide brief description of what your template does and how do you think this can help the existing connector? Does this add a missing piece, or it is simply another way of creating the same connector? Thanks

v-spadarthi avatar Sep 30 '22 04:09 v-spadarthi

@chrisjaimon2012 Can you please provide brief description of what your template does and how do you think this can help the existing connector? Does this add a missing piece, or it is simply another way of creating the same connector? Thanks

Hi @chrisjaimon2012, Can you please address the above comments. Thanks

v-mchatla avatar Oct 04 '22 20:10 v-mchatla

@chrisjaimon2012 Can you please provide brief description of what your template does and how do you think this can help the existing connector? Does this add a missing piece, or it is simply another way of creating the same connector? Thanks

@chrisjaimon2012, can you please provide your thoughts on this, thanks.

v-sabiraj avatar Oct 07 '22 04:10 v-sabiraj

@chrisjaimon2012 Can you please provide brief description of what your template does and how do you think this can help the existing connector? Does this add a missing piece, or it is simply another way of creating the same connector? Thanks

Hi @chrisjaimon2012, Can you please address the above comments. Thanks

v-spadarthi avatar Oct 11 '22 06:10 v-spadarthi

Hi @chrisjaimon2012, Can you please address the above comments. Thanks

v-spadarthi avatar Oct 13 '22 14:10 v-spadarthi

Hi @chrisjaimon2012, Can you please address the above comments. Thanks

v-spadarthi avatar Oct 17 '22 07:10 v-spadarthi

@chrisjaimon2012 : We wanted to check on the status of PR https://github.com/Azure/Azure-Sentinel/pull/5656 . PR is pending from more than 60 days. Let us know if any assistance is required for this PR. As Per our standard operating procedures if no response is received in the next 7 business days we will close this PR. Thank you for your cooperation.

v-spadarthi avatar Oct 18 '22 07:10 v-spadarthi

We are waiting for the update from author. Thanks!

v-spadarthi avatar Oct 20 '22 07:10 v-spadarthi

We are waiting for the update from author. Thanks!

v-spadarthi avatar Oct 25 '22 07:10 v-spadarthi

We are waiting for the update from author. Thanks!

v-spadarthi avatar Oct 28 '22 04:10 v-spadarthi

Hi @chrisjaimon2012 Since we have not received response from last 7 days, we are closing your PR per our standard operating procedures. If you still need support for this issue you can re-open the PR at any time. If you do re-open, we simply request that you ensure the PR has response to the last request. Thank you for your cooperation.

v-spadarthi avatar Oct 31 '22 06:10 v-spadarthi