Azure-Sentinel icon indicating copy to clipboard operation
Azure-Sentinel copied to clipboard

createSolution.ps1 doesnt handle custom connector

Open dicolanl opened this issue 2 years ago • 5 comments

When running createSolution.ps1 to create a solution, it leaves a null field in the createUiDefintion.json if the playbook is not a playbook but is a custom connector.

On line 312, it uses $playbookName for the label. $playbookName comes from line 270 which gets the name from the template if it has a "PlaybookName" or "Playbook Name" parameter. A custom connector would not have a playbook name parameter in the ARM template.

To Reproduce Steps to reproduce the behavior:

  1. run createSolution.ps1 on a solution that has a custom connector in the Playbooks folder in the solution.

dicolanl avatar Jul 06 '22 20:07 dicolanl

Thank you for submitting an Issue to the Azure Sentinel GitHub repo! You should expect an initial response to your Issue from the team within 5 business days. Note that this response may be delayed during holiday periods. For urgent, production-affecting issues please raise a support ticket via the Azure Portal.

github-actions[bot] avatar Jul 06 '22 20:07 github-actions[bot]

Thank you for submitting an Issue to the Azure Sentinel GitHub repo! You should expect an initial response to your Issue from the team within 5 business days. Note that this response may be delayed during holiday periods. For urgent, production-affecting issues please raise a support ticket via the Azure Portal.

github-actions[bot] avatar Jul 12 '22 23:07 github-actions[bot]

Thank you for submitting an Issue to the Azure Sentinel GitHub repo! You should expect an initial response to your Issue from the team within 5 business days. Note that this response may be delayed during holiday periods. For urgent, production-affecting issues please raise a support ticket via the Azure Portal.

github-actions[bot] avatar Oct 18 '22 08:10 github-actions[bot]

Thank you for submitting an Issue to the Azure Sentinel GitHub repo! You should expect an initial response to your Issue from the team within 5 business days. Note that this response may be delayed during holiday periods. For urgent, production-affecting issues please raise a support ticket via the Azure Portal.

github-actions[bot] avatar Mar 20 '23 12:03 github-actions[bot]

Thank you for submitting an Issue to the Azure Sentinel GitHub repo! You should expect an initial response to your Issue from the team within 5 business days. Note that this response may be delayed during holiday periods. For urgent, production-affecting issues please raise a support ticket via the Azure Portal.

github-actions[bot] avatar Apr 12 '23 04:04 github-actions[bot]

We wanted to check on the status of Issue https://github.com/Azure/Azure-Sentinel/issues/5562. The issue is pending for more than expected days. Please let us know if you need any assistance to review this Issue. As per our standard operating procedures if no response is received in the next 7 business days, we will close this Issue. Thank you for your cooperation.

v-rbajaj avatar Jun 07 '23 12:06 v-rbajaj

Hi @v-rbajaj No one ever fixed this, its still an issue.

dicolanl avatar Jun 07 '23 12:06 dicolanl

Hi @dicolanl can you please confirm if you have a parameter with alias '"CustomConnectorName" in azuredeploy file of custom connector and same should be present in associated playbooks' parameters too, the script works fine if these requirements are met, please let us know if you're looking for something else, thanks!

v-vdixit avatar Jun 15 '23 10:06 v-vdixit

Gentle Reminder: We are waiting for your response on this issue. If you still need to keep this issue active, please respond on it in the next 2 days. If we don't receive response, we will be closing this issue as per our standard procedures, thanks!

v-vdixit avatar Jun 21 '23 09:06 v-vdixit

Since we have not received a response in the last 5 days, we are closing your issue as per our standard operating procedures. If you still need support for this issue, feel free to re-open at any time. Thank you for your co-operation

v-vdixit avatar Jun 23 '23 12:06 v-vdixit

Thank you for submitting an Issue to the Azure Sentinel GitHub repo! You should expect an initial response to your Issue from the team within 5 business days. Note that this response may be delayed during holiday periods. For urgent, production-affecting issues please raise a support ticket via the Azure Portal.

github-actions[bot] avatar Jun 23 '23 12:06 github-actions[bot]